Closed
Bug 355344
Opened 15 years ago
Closed 14 years ago
Exceptions thrown by watchpoint show up in the next call to "eval"
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha1
People
(Reporter: jruderman, Assigned: mrbkap)
Details
(Keywords: testcase, verified1.8.1.1)
Attachments
(1 file)
1016 bytes,
patch
|
brendan
:
review+
brendan
:
approval1.8.1.1+
|
Details | Diff | Splinter Review |
js> this.watch('x', function(){throw 'yikes'}); x = 3; try { eval("") } catch(e) { print("caught: " + e); } caught: yikes
Assignee | ||
Comment 1•14 years ago
|
||
We weren't propagating the ok return value correctly...
Assignee | ||
Updated•14 years ago
|
OS: Mac OS X 10.4 → All
Priority: -- → P3
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.9alpha
Updated•14 years ago
|
Attachment #244278 -
Flags: review?(brendan)
Attachment #244278 -
Flags: review+
Attachment #244278 -
Flags: approval1.8.1.1+
Updated•14 years ago
|
Flags: blocking1.8.1.1?
Assignee | ||
Comment 2•14 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
Checking in regress-355344.js; /cvsroot/mozilla/js/tests/js1_5/Regress/regress-355344.js,v <-- regress-355344.js initial revision: 1.1 done
Flags: in-testsuite+
Comment 4•14 years ago
|
||
2006110700 windows/linux: The testcase fails in the browser with: Expected value 'setter: yikes', Actual value ''. Changing it so the test is at a top level script still fails. Changing the script so that you use a different object and watch its x property will pass however. Is the test as checked in wrong? Or is it a bug that watching |this.x| either in the test() function or at the top level fails in the browser?
Updated•14 years ago
|
Flags: blocking1.8.1.1? → blocking1.8.1.1+
Comment 6•14 years ago
|
||
Fixed on the 1.8 branch: Checking in jsdbgapi.c; /cvsroot/mozilla/js/src/jsdbgapi.c,v <-- jsdbgapi.c new revision: 3.56.2.8; previous revision: 3.56.2.7 done /be
Keywords: fixed1.8.1.1
Comment 7•14 years ago
|
||
verified fixed 20061125 1.8.1.1 windows/linux/mac*, 1.9 windows/linux
Keywords: fixed1.8.1.1 → verified1.8.1.1
Comment 8•14 years ago
|
||
modified test to use user defined object to watch instead of |this| to help improve reproducibility in test library. I've been running locally with this modification for some time. Checking in regress-355344.js; /cvsroot/mozilla/js/tests/js1_5/Regress/regress-355344.js,v <-- regress-355344.js
You need to log in
before you can comment on or make changes to this bug.
Description
•