355344 - Exceptions thrown by watchpoint show up in the next call to "eval"

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Jesse Ruderman]

js> this.watch('x', function(){throw 'yikes'}); x = 3; try { eval("") } catch(e) { print("caught: " + e); }

caught: yikes

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

We weren't propagating the ok return value correctly...

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 3

[Bob Clary [:bc] (inactive)]

Checking in regress-355344.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-355344.js,v  <--  regress-355344.js
initial revision: 1.1
done

Comment 4

[Bob Clary [:bc] (inactive)]

2006110700 windows/linux: The testcase fails in the browser with: 
Expected value 'setter: yikes', Actual value ''. Changing it so the test is at a top level script still fails. Changing the script so that you use a different object and watch its x property will pass however. 

Is the test as checked in wrong? Or is it a bug that watching |this.x| either in the test() function or at the top level fails in the browser?

Comment 5

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20061108 windows/linux

Comment 6

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch:

Checking in jsdbgapi.c;
/cvsroot/mozilla/js/src/jsdbgapi.c,v  <--  jsdbgapi.c
new revision: 3.56.2.8; previous revision: 3.56.2.7
done

/be

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 20061125 1.8.1.1 windows/linux/mac*, 1.9 windows/linux

Comment 8

[Bob Clary [:bc] (inactive)]

modified test to use user defined object to watch instead of |this| to help improve reproducibility in test library. I've been running locally with this modification for some time.

Checking in regress-355344.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-355344.js,v  <--  regress-355344.js