355434 - Change LDAP C SDK version to 6

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Rich Megginson]

With all of the new features and API changes, we need to change the version to 6 for the new release.

Comment 1

[Rich Megginson]

Attachment: diffs for fix

The default vendor version is changed to 600.  The actual version is 6.0.0, and we will use this version numbering scheme with external releases, cvs tags, etc. which is more compatible with NSPR, NSS, and other Mozilla components.  In addition, this changes the shared library name suffix from 50 to 6.  The single digit is also more compatible with NSPR, NSS, etc.

Comment 2

[Mark Smith [:mcs]]

Comment on attachment 241225 [details] [diff] [review]
diffs for fix

Looks good to me.  I hope no other hard-coded version numbers have crept into the code elsewhere (I do not think so).  Do we need to commit new Windows .def files?

Comment 3

[Rich Megginson]

Attachment: new diffs that include .def files

I think the .def files are automatically generated.  I went ahead and reversioned them as well.

Comment 4

[Anton Bobrov]

(In reply to comment #3)

Rich, i have two comments and one request regarding this:

- you probably wanna fix rpm templates/scripts there as well.
- *nix and doze makefiles for examples have to be fixed if 
  you have time and its an easy change tho sure not critical.

and the request i have is can we stick with old naming conv ?
what i mean by this: replacing "6" with "60". see, the thing
is we already have 6 out with old naming conv "50"->"60" and
few projects/users already adopted it and while it probably
doesnt bear much sence to have "60" there i would hate asking
all those folks to adjust all their scripts/templates again.

> Created an attachment (id=241229) [edit]
> new diffs that include .def files

Comment 5

[Rich Megginson]

Attachment: new diffs that use 60 and update example and spec files

Thanks Anton.  These diffs use 60 instead of 6 for lib suffix naming, update the example makefiles, and update the rpm spec file and build script.
I had to change the package name to mozldap6 - we will be releasing a version of mozldap version 5, which is called simply "mozldap".  We need to be able to install mozldap6 on the same machine as mozldap.  The new package naming is the only way to do that.

Comment 6

[Rich Megginson]

Attachment: same as previous diffs but with configure diffs omitted

These diffs omit the configure diffs which are hard to read and confusing.
One more change I had to make was to the configure script.  On fedora/rhel, you are supposed to use %configure in the spec file instead of ./configure.  The %configure macro supplies many additional configure flags, among them --host, --target, and --build.  The way the configure script handles cross compilation is not ideal, so I had to change it.  You trigger a cross compile by specifying a --host on the command line.  According to http://www.gnu.org/software/autoconf/manual/autoconf-2.57/html_mono/autoconf.html
  specifying a --host different from --build triggers a cross compile.  However, the mozilla build system uses --target instead of --build.  And the %configure macro sets --host to a different value than --target, but sets --host to the same value as --build.  So I had to add additional logic to appease both mozilla and %configure.

Comment 7

[Anton Bobrov]

(In reply to comment #5 & #6)
> Thanks Anton.  These diffs use 60 instead of 6 for lib suffix naming, update
> the example makefiles, and update the rpm spec file and build script.

thanx a bunch Rich!

> I had to change the package name to mozldap6 - we will be releasing a version
> of mozldap version 5, which is called simply "mozldap".  We need to be able to
> install mozldap6 on the same machine as mozldap.  The new package naming is the
> only way to do that.

i'm totally kewl with that.

Comment 8

[Rich Megginson]

Attachment: cvs commit log

commit log