355470 - rebase throwing error 99 on tinderboxes with VC8

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Matthew (lilmatt) Willis]

rebase is throwing error 99 on the tinderboxes that have been upgraded to VC8.

From sb-win32-tbox:
 echo rebasing ./dist
 rebasing ./dist
 /bin/find ./dist -name "*.dll" > rebase.lst
 rebase -b 60000000 -R . -G rebase.lst

 REBASE: Total Size of mapping 0x0000000000670000
 REBASE: Range 0x0000000060000000 -0x0000000060670000
 make: *** [rebase] Error 99


From gaius-vm (building Minefield):
 echo rebasing ./dist
 rebasing ./dist
 /bin/find ./dist -name "*.dll" > rebase.lst
 rebase -b 60000000 -R . -G rebase.lst

 REBASE: Total Size of mapping 0x0000000000bd0000
 REBASE: Range 0x0000000060000000 -0x0000000060bd0000
 make: *** [rebase] Error 99

Comment 1

[(not currently active) Ted Mielczarek]

Still a problem on fx-win32-tbox, fwiw.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

What is the impact of this bug ?

Comment 3

[Benjamin Smedberg]

Rebasing DLLs improves startup time, in some cases significantly.

I'd nominate this for blocking-ff3 if I could.

Comment 4

[(not currently active) Ted Mielczarek]

Via random googling, I speculate that this is due to us trying to rebase the CRT DLLs.  I don't have a compiler working right now, so I can't test this theory.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

rebase -v output:

...
REBASE:        xpcom.dll initial base at 0x0000000010000000 (size 0x00007000)
REBASE:        xpcom.dll rebased to 0x0000000061a30000 (size 0x00010000)

REBASE: Total Size of mapping 0x0000000001a40000
REBASE: Range 0x0000000060000000 -0x0000000061a40000
REBASE: msvcm80.dll      Rebase failed.  Strong signed images can not be rebased.
REBASE: msvcm80.dll      Rebase failed.  Strong signed images can not be rebased.
make: *** [rebase] Error 99

Ted wins!

Comment 6

[(not currently active) Ted Mielczarek]

From the log output, it looks like we're successfully rebasing our other DLLs, so this isn't a big deal.  It should be easy enough to patch this to ignore msvc*dll to get rid of the error.

Comment 7

[(not currently active) Ted Mielczarek]

Attachment: filter out msvc*dll from rebase

Pretty trivial, just filter out msvc*dll from the list of dlls to be rebased.

Comment 8

[Benjamin Smedberg]

Comment on attachment 269225 [details] [diff] [review]
filter out msvc*dll from rebase

I probably would have used

/bin/find -name "*.dll" -a -not -name "msvc*"

but I guess the grep solution works too ;-)

Comment 9

[(not currently active) Ted Mielczarek]

That sounds better, I checked it in with that change.