Closed Bug 355577 Opened 13 years ago Closed 13 years ago

storage calendar can use some indexes

Categories

(Calendar :: Provider: Local Storage, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Sunbird 0.5

People

(Reporter: mvl, Assigned: mvl)

Details

(Whiteboard: [patch in hand])

Attachments

(1 file)

The database used by the storage provider can use some indexes. Low-hanging fruit for performance.
For example, I added an index on cal_properties.item_id, and it made one testcase almost twice as fast (getting all items from a 750 item calendar)
There might very well be other places that can use an index.

code to create said index:
create index cal_properies_item_id on cal_properties(item_id);

This might need another schema update.
This could go in with the schema update in bug 333688
Depends on: 333688
Attached patch patch v1Splinter Review
patch add the index, if it doesn't already exists. I think this is more flexible in the future then creating a new schema version. It might be a small startup hit, but i think that's small enough.
Assignee: nobody → mvl
Status: NEW → ASSIGNED
Attachment #244000 - Flags: first-review?(jminta)
Since this doesn't need a schema update, removing dependency on bug 333688.
No longer depends on: 333688
Whiteboard: [patch in hand][needs review jminta]
Priority: -- → P1
Target Milestone: --- → Sunbird 0.5
Comment on attachment 244000 [details] [diff] [review]
patch v1

r=jminta if you break the line up to fit under the 80char limit.
Attachment #244000 - Flags: first-review?(jminta) → first-review+
Whiteboard: [patch in hand][needs review jminta] → [patch in hand]
patch checked in.
closing this bug, new bugs can always be opened for more indices.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.