355577 - storage calendar can use some indexes

Status: RESOLVED FIXED

(Calendar :: Provider: Local Storage, defect, P1)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

The database used by the storage provider can use some indexes. Low-hanging fruit for performance.
For example, I added an index on cal_properties.item_id, and it made one testcase almost twice as fast (getting all items from a 750 item calendar)
There might very well be other places that can use an index.

code to create said index:
create index cal_properies_item_id on cal_properties(item_id);

This might need another schema update.

Comment 1

[Matthew (lilmatt) Willis]

This could go in with the schema update in bug 333688

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

patch add the index, if it doesn't already exists. I think this is more flexible in the future then creating a new schema version. It might be a small startup hit, but i think that's small enough.

Comment 3

[Matthew (lilmatt) Willis]

Since this doesn't need a schema update, removing dependency on bug 333688.

Comment 4

[Joey Minta]

Comment on attachment 244000 [details] [diff] [review]
patch v1

r=jminta if you break the line up to fit under the 80char limit.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in.
closing this bug, new bugs can always be opened for more indices.