35560 - Cookie Manager loses scrollbar after switching tabs

Status: VERIFIED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[gstoll]

(Sorry - not exactly sure where to put this...)
In Linux Build ID 2000041109, you can make the Cookie Manager loses the scroll
bar (the arrows at the end are still there and function - there is just white
space between them), and then freeze.

To reproduce:
1) Open Tasks->Personal Managers->Cookie Manager->View Stored Cookies
2) Click on "Cookie Sites" in the upper tabbing thing.
3) Click back on "Stored Cookies" in aforementioned tabbing thing.  Scroll bar
will turn white, as mentioned above.  Cookie Manager _might_ freeze.
4) If it hasn't frozen yet, scroll down (using arrows at top and bottom of
scroll bar), and try to click on a cookie.  It should freeze, and you have to
close it (not kill it, thankfully).

Expected results: Cookie manager doesn't freeze, and scroll bar doesn't disappear!

Comment 1

[Sean Richardson]

Confirmed as reported with the 2000-04-11-08-M15 nightly binary on WinNT 4.0.
Setting OS to All.

On trials where the window did not immediately freeze, it was possible to 
use the scrollbar blindly in "paging" mode, by clicking above or below where
the slider ought to be. Sometimes the window would freeze during this.

The missing scrollbar here seems similar to bug 34652, "scrollbar slider 
disappearing after minimize [of browser]" -- switching away from a tab
and back seems conceptually similar to minimizing and restoring.

CC-ing the Cookies owner in case this is more a Cookies bug.
The freeze is easier to reproduce the first few times; closing and restarting
Mozilla re-primes the pump.

Comment 2

[Stephen P. Morse]

Yep, it sure does lose the scrollbar and hang.  Reproduced using an old build 
(from April 5) so this is not a very recent regression.

Copying hyatt and ben on this since they are the ones most involved with this.

Comment 3

[Stephen P. Morse]

BTW, in case it wasn't obvious, you need to first collect more than eight 
cookies in order to demonstrate this bug.  Less than that and there is no scroll 
bar to vanish.

Comment 4

[David Hyatt]

Did Nisheeth land his FlushPendingNotifications code without checking the tree 
first?  Nisheeth, can you comment?

Comment 5

[Nisheeth Ranjan]

Nope, my code is still in my tree.  I'm planning to update my tree and check it 
in tomorrow.  Re-assigning this bug to joki who had it before hyatt re-assigned 
it to me.

Comment 6

[Phil Peterson]

[nsbeta2+]

Comment 7

[joki (gone)]

I don't know whose this is but unless the description is very misleading its not 
mine.  Anyone want to volunteer?

Comment 8

[Nisheeth Ranjan]

Setting target milestone and re-assigning to myself.  I'll look into this and 
see who should get this bug.

Comment 9

[Nisheeth Ranjan]

Updating status whiteboard...

Comment 10

[Nisheeth Ranjan]

I'm attaching a reduced test case for the "scrollbars disappear" problem.  When 
you load this attachment, you'll see scrollbars on the tree widget.  

1) Click on the "Cookie Sites" tab.  A new tab with text "Placeholder Text" will 
be displayed.
2) Click on the "Stored Cookies" tab.  The tree widget will become visible 
again, but the scrollbars will have disappeared.

I could not reproduce the freezing problem anymore.

I'm re-assigning this to hyatt, the tree owner.

Comment 11

[Nisheeth Ranjan]

Updating summary and status whiteboard...

Comment 12

[Nisheeth Ranjan]

Attachment: test.xul

Comment 13

[Nisheeth Ranjan]

One more comment: I would recomment that the priority of this bug be lowered.  
Since the app does not freeze anymore and the scrollbars only disappear when the 
user switches tabs, I don't think this bug is a beta 2 blocker.

Comment 14

[Stephen P. Morse]

I can reproduce the freezing problem quite reliably as follows: after you lose 
the scrollbar, click on the place where the scrollbar is supposed to be.  At 
this point you are frozen.

That's how to freeze the actual cookie viewer.  I haven't tried it with the test 
xul that Nisheeth attached, so I don't know if that will freeze or not.

Comment 15

[David Hyatt]

requesting reconsideration.  given that the tree is being re-written on top of 
grid in beta3, it seems bad to waste my time on throwaway code.

Comment 16

[Peter Trudelle]

removing "[nsbeta2]" from status whiteboard to avoid any confusion.

Comment 17

[Stephen P. Morse]

This bug lead to a freeze of the dialog.  So even if the code is being rewritten 
in the future, something needs to be done to make the dialog stable in beta2.

Comment 18

[Peter Trudelle]

Moving all bugs that are not dogfood+, nsbeta2+,features, or nsbeta2- to M21

Comment 19

[Stephen P. Morse]

This bug was nominated for nsbeta2 and received an nsbeta2+ from pdt.  Hyatt has 
now asked for reconsideration.  Consequently it will become either nsbeta2+ 
again or it will become nsbeta2-.  So according to the criteria that you stated 
above, this one shouldn't have been moved to m21.

It is a freeze of the dialog and as such should be given more immediate 
consideration.

Comment 20

[Peter Trudelle]

[nsbeta2+] could be fixed by tree rewrite?

Comment 21

[David Hyatt]

fixed.

Comment 22

[Stephen P. Morse]

How can this be marked fixed when you now lose all the cookies after switching 
tabs.  There's no way this could possibly be tested.  See bugs 43203/43206.

Comment 23

[David Hyatt]

yes, but i know the new tree is incapable of having this problem, so i know this 
won't be a problem any more.  if you want me to leave it open until the other 
bugs are fixed, i can do so, but i'm sure this won't be an issue with the new 
tree.

Comment 24

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 25

[David Hyatt]

fixed.

Comment 26

[Stephen P. Morse]

This bug is *not* fixed, it's worse.  Now we don't even have a scrollbar to 
lose.  That is, the original tree, before doing any tabbing, simply stops when 
it gets to the bottom of the tree area and there is no way to see those cookies 
that didn't make it in the top eight (or however many fit in the original 
display).

Comment 27

[Mike Pinkerton (not reading bugmail)]

steve, could this new behavior be a dupe of 43467 or 43459, both well known tree 
bugs to do with scrolling?

Comment 28

[Stephen P. Morse]

Yes, this could possibly be a dup of either 43467 and/or 43459.  But I could say 
for certain.

Comment 29

[Stephen P. Morse]

With a recent tree, I am no longer seeing any scrolling problems with the 
cookie viewer.  Closing out this report.

Comment 30

[Stephen P. Morse]

.

Comment 31

[ckritzer (gone)]

Mass update:  changing qacontact to [e-mail]

Comment 32

[Sean Richardson]

Testing with 2000-08-01-04-M17 on WinNT, the scrollbar works as advertised
after switching tabs.

Comment 33

[ckritzer (gone)]

On LinRH6 2000-08-02-04-M17:
This bug does not appear.  Checking Mac & Windows next...

Comment 34

[ckritzer (gone)]

Marking VERIFIED WORKSFORME on:
 - MacOS9 2000-08-02-04-M17 Commercial Build
 - Linux6 2000-08-02-04-M17 Commercial Build
 - Win98  2000-08-02-05-M17 Commercial Build