355832 - "Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE" or null deref [@ js_FindProperty] with "let" that binds nothing

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jesse Ruderman]

debug:
js> let ([] = []) { }
Assertion failure: OBJ_GET_CLASS(cx, obj)->flags & JSCLASS_HAS_PRIVATE, at jsapi.c:2368

opt:
js> let ([] = []) { print(3) } print(4)
3
Bus error

(Btw, the code is similar to the code in bug 355635, but here we're running it instead of decompiling it.)

Comment 1

[Jesse Ruderman]

This is one of the most common bugs the fuzzer in bug 349611 hits.

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

The test in JSOP_SETSP predates empty destructuring patterns, which we ECMA TG1ers agreed was desirable, late in the 1.8.1 cycle.  Likewise the sp in range assertion in JSOP_LEAVEBLOCK{,EXPR}.

/be

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 245997 [details] [diff] [review]
fix

approved for 1.8 branch, a=dveditz for drivers

Comment 4

[Brendan Eich [:brendan]]

Fixed on trunk:

Checking in jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.304; previous revision: 3.303
done

and in the 1.8 branch:

Checking in jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.181.2.70; previous revision: 3.181.2.69
done

/be

Comment 5

[Bob Clary [:bc] (inactive)]

RCS file: /cvsroot/mozilla/js/tests/js1_7/regress/regress-355832-01.js,v
done
Checking in regress-355832-01.js;
/cvsroot/mozilla/js/tests/js1_7/regress/regress-355832-01.js,v  <--  regress-355832-01.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/regress/regress-355832-02.js,v
done
Checking in regress-355832-02.js;
/cvsroot/mozilla/js/tests/js1_7/regress/regress-355832-02.js,v  <--  regress-355832-02.js
initial revision: 1.1
done

Comment 6

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.1.1 windows/mac*/linux, 1.9 windows/linux