$ signs in WARN_APP_RUNNING_INSTALL

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: marcoos, Assigned: pkst)

Tracking

({verified1.8.1.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This is the same problem as reported for Polish in bug 355966.

Probably while migrating strings from commonLocale.nsh to custom.properties, the Greek teamsomehow didn't notice the .nsh-ish endlines: $\r$\n$\r$\n in
WARN_APP_RUNNING_INSTALL. 

This makes the dollar signs visible in the window with that error message.

The endlines should be changed to just "\n\n".
Created attachment 244839 [details] [diff] [review]
Patch for browser

Fixing browser, as this WFMs in mail now.

pkst, you may want to have this checked-in for 2.0.0.1. 

You should also request approval1.8.1.1 from Pike for checking this in.
Attachment #244839 - Flags: review?(pkst)
(Assignee)

Comment 3

12 years ago
Comment on attachment 244839 [details] [diff] [review]
Patch for browser

Marek thanks  for the point and the patch. Requesting  approval for 1.8.1.1
Attachment #244839 - Flags: review?(pkst)
Attachment #244839 - Flags: review+
Attachment #244839 - Flags: approval1.8.1.1?

Comment 4

12 years ago
Comment on attachment 244839 [details] [diff] [review]
Patch for browser

[el] approving installer fix for firefox 2.0.0.1

Please use the fixed1.8.1.1 and verified1.8.1.1 keywords to track landing and testing.
Attachment #244839 - Flags: approval1.8.1.1? → approval1.8.1.1+
(Assignee)

Updated

12 years ago
Keywords: fixed1.8.1.1
(Assignee)

Updated

12 years ago
Keywords: fixed1.8.1.1 → verified1.8.1.1
You may want to fix that on trunk as well.
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.