356032 - Tab removes quote marks from recipient addresses with commas when typed in address line

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect)

Description

[Craig Emery]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7

If you address an email to someone with commas in their name and hit tab, the quotes are removed

Reproducible: Always

Steps to Reproduce:
1. Compose a new email
2. Enter the email name "Last, First" <[e-mail]>
3. Type a tab
Actual Results:  
"Last, First" <[e-mail]> changed to
Last, First <[e-mail]>

Expected Results:  
Recipient should be left alone.

If instead of typing TAB I type Alt-S, I can jump to the subject field, so I guess this is a workaround.

Comment 1

[Mike Cowperthwaite]

I'm not able to reproduce this problem.  Do you have any extensions installed?
If so, does the problem persist when you run TB in Safe Mode?

Comment 2

[Craig Emery]

The problem does persit with all extensions disabled.
However, I have installed:
about:config
Enigmail
View Headers Toggle Button
MinimizeToTray

I shall try a fresh profile and report.
Craig

Comment 3

[Craig Emery]

I created a frash new profile in TB 1.5.0.7 (win32)
I created a new email composition and entered the address (quotes included)
"emery, craig" <cemery>
and then I type TAB.
The quotes vanish.
Craig

Comment 4

[Mike Cowperthwaite]

(In reply to comment #3)
> I created a frash new profile in TB 1.5.0.7 (win32)
> I created a new email composition and entered the address (quotes included)
> "emery, craig" <cemery>
> and then I type TAB.
> The quotes vanish.

OK, I can reproduce this... but if you type
  "emery, craig" <[e-mail]>
the quotes remain.  TB won't handle the email address <cemery>, it requires a domain to work, so it's probably parsing as invalid.

Worse:  If you enter:
  "craig emery" <cemery>
the quotes are left in but the autocomplete-to-domain (if you have that turned on) is bogusly applied to the entire string; I see:
  "craig emery" <cemery>@well.com
That's a different bug, altho you're more likely to leave off the domain qualification yourself if you expect autocomplete-to-domain.

Reproduced with TB 1.5.0.7 and 3a1-1009, Win2K.

Comment 5

[Craig Emery]

Well the absense of a domain isn't /really/ invalid as the MDA gets to decide that. That's why I've installed the localdomain TB extension so that the function CheckValidEmailAddress(to, cc, bcc) always returns true.

You see I'm not typing these addresses in, they're coming from my employers LDAP server! My employer employs about 9000 people and the majority of them use Outlook. The LDAP server may even be an exchange server that also does LDAP.

All these little things get in the way of TB being widely adopted in commercial environments.

If anyone has an idea where the code that's called when tab it typed is, I'll submit a patch.

Of course I only need this because the LDAP server returns email addresses without domains. If anyone wants to give me a clue as to where I could interject a domain into the returned addresss I'd be happy with that too (maybe even more than disabling the domain-present check).

Comment 6

[Mike Cowperthwaite]

Hmm.  See bug 312818, also bug 131692.

I don't know if this is helpful, but there's an old (and probably no-longer-applicable) patch at bug 168204 that might give you a starting point.  You could also try a search for Fixed bugs with "auto complet" in the summary for other patch examples.

If you get deep enough into this to patch it, I can point you to a couple of other bugs with autocomplete forcing a major misparse which also need fixing... :)

Comment 7

[Wayne Mery (:wsmwk)]

fails also on trunk (and TB 2.0.0.13) - using "emery, craig" <cemery>
and per comment 5

Comment 8

[ovidiu]

maybe bug 440377 alike

Comment 9

[Mike Cowperthwaite]

FWIW, the symptom in comment 3 no longer manifests in trunk builds, at least not when I just tested with 3pre2-0621.  Craig, if that's sufficient for you, pls resolve the bug WorksForMe.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Wayne, can you still reproduce this bug? I'm not able to with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.18pre) Gecko/20080926 Thunderbird/2.0.0.17pre Mnenhy/0.7.5.0 ID:2008102603

Comment 11

[Wayne Mery (:wsmwk)]

hm, I can't repro with version 2.0.0.13pre (20080227). This finding conflicts with my comment 7, so perhaps I'm a not a good person to be testing today.

Comment 12

[Wayne Mery (:wsmwk)]

=> WFM a buncha people