Closed Bug 356080 Opened 18 years ago Closed 18 years ago

Disabled-state for menuitems with a command set is never updated

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: asaf, Assigned: jaas)

References

Details

Attachments

(1 file)

fix v1.0
1.28 KB, patch
asaf
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
The disabled state of menuitems without a command set is never updated, see code in nsMenuItemX::AttributeChanged.
*** Bug 346955 has been marked as a duplicate of this bug. ***
Attached patch fix v1.0 — — Splinter Review 

        Attachment #241907 -
        Flags: review?

    
  

        Attachment #241907 -
        Flags: review? → review?(mano)

    
    

    
  
See duped bug 346955 for an example of the problems this causes.

    
    

    
  
Comment on attachment 241907 [details] [diff] [review]
fix v1.0

r=mano

        Attachment #241907 -
        Flags: review?(mano) → review+

    
  

        Attachment #241907 -
        Flags: superreview?(mikepinkerton)

    
    

    
  
Comment on attachment 241907 [details] [diff] [review]
fix v1.0

i don't think it should be case-sensitive, but it appears we are in lots of other places too...

sr=pink

        Attachment #241907 -
        Flags: superreview?(mikepinkerton) → superreview+

    
    

    
  
fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: