356086 - Refactor Content-Disposition Handling

Status: RESOLVED DUPLICATE of bug 589292

(Core :: Networking, defect)

Description

[Robert Sayre]

HttpChannel should know its own content-disposition, so we can factor the code that's getting all over the tree. See bug 355332.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

seems familiar to me, are you sure it's not a duplicate?

Comment 2

[Robert Sayre]

(In reply to comment #1)
> seems familiar to me, are you sure it's not a duplicate?

nope.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I don't think we have a separate bug on this.  It came up in bug 224209, but that's all I can find.

Comment 4

[Przemyslaw Bialik]

(In reply to comment #1)
> seems familiar to me
Bug 299372 ?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Absolutely not.

Comment 6

[Jason Duell]

renamed bug, as we want this for the JAR and Multipart channels as well, and to unify their interface.  The current plan is to make them all inherit from nsPropertyBag, and store the disposition info there.

This is already done for nsJARChannel (bug474536)--I'm going to implement for the other two.

So far I've put just the raw header in ("attachment; filename=foo.jar"), but I may add logic to split the attachment and filename parts, and store them separately as "content-disposition" and "content-disposition-filename."  Right now we're doing a lot of duplicate parsing of the raw header in various places, which is silly and probably error-prone.   Cleaning up the various usage sites is also part of this bug.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Jason, you're not working on this anymore are you?

Comment 8

[Jason Duell]

Kyle,

No.  The code is working, and refactoring it isn't even close to the top of my todo list.

Comment 9

[Jason Duell]

Kyle,

We're in the middle of trying to rip out the entire nsPropertyBag interface from channels (it doesn't work well with electrolysis), and we haven't figured out how that will look yet, so I'd recommend working on something else for now.

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to comment #9)
> Kyle,
> 
> We're in the middle of trying to rip out the entire nsPropertyBag interface
> from channels (it doesn't work well with electrolysis), and we haven't figured
> out how that will look yet, so I'd recommend working on something else for now.

Heh, ok.  Guess I'll abandon this for now.

Comment 11

[Jason Duell]

We'll fix this in 589292