356111 - New tinderbox needed for Places

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Dan Mills [:thunder]]

Problem:

Current tinderbox builds:

a) build with places disabled.
b) run tests with no history data in the profile.

In order to start hacking on places, we need both of these.  We propose the following solution:

* Set up a new tinderbox with places enabled
* Set up new tests with history data, for both places *and* non-places builds.

The second part may require setting up new tinderboxes, or hacking the test code so it can be separated from the build portion some more.

I'm sure there are other details I'm missing, but hopefully this will get the ball rolling.

Comment 1

[Dan Mills [:thunder]]

Knowing the relative difficulty in setting up the different platforms, we (the places team) would be happy with building only on win32 for the time being.

As for the testing requirement, I will provide a patch to add new tests with history data.

Comment 2

[Dan Mills [:thunder]]

The only thing that's needed to turn on places is to add:

ac_add_options --enable-places

to the mozconfig.  Any other settings that are usually used for tinderboxen can remain.

The places stuff is all on the trunk, not in a branch.

Comment 3

[Robert Helmer [:rhelmer]]

Tinderbox build set up on fxexp-win32-tbox, publishing to MozillaExperimental tree:
http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaExperimental 

Name is "WINNT 5.2 fxexp-win32-tbox Dep Places".

Comment 4

[Dan Mills [:thunder]]

Attachment: Add a Tp test with history

I'm unsure if the method for specifying which files to copy in is adequate, I went with a simple hash mapping destination filenames => full source paths.

The test assumes the files have been checked out already.  I think we should add a hook to check out additional files, similar to $TreeSpecific::extrafiles.  Thoughts?

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to comment #4)
> Created an attachment (id=245054) [edit]
> Add a Tp test with history


Looks good; I am going to do some tests before checking in.


> I'm unsure if the method for specifying which files to copy in is adequate, I
> went with a simple hash mapping destination filenames => full source paths.


Doesn't seem to be any standard way to do this in Tinderbox.


> The test assumes the files have been checked out already.  I think we should
> add a hook to check out additional files, similar to $TreeSpecific::extrafiles.
>  Thoughts?

 
I've been wanting something like this; multi-tinderbox.pl is able to update an existing mozilla checkout, but it's not quite the same thing.

Might be worth thinking about this in the context of the extracted tests.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: add --enable-places to mozconfig

Following Dietrich's news post (http://groups.google.com/group/mozilla.dev.apps.firefox/browse_frm/thread/232dff63b9d8848a/683cc0f3681b06a5?#683cc0f3681b06a5), JP Baker pointed out that the builds from fxexp-win32-tbox don't actually enable places.

The tinderbox config seems to confirm this, eg if you look near the top of a full log (like this one for the last nightly http://tinderbox.mozilla.org/showlog.cgi?log=MozillaExperimental/1165408920.7546.gz&fulltext=1) there is no --enable-places in the mozconfig. Which matches the config in mozilla/tools/tinderbox-configs/firefox/win32/mozconfig on the feature_places branch.

Not sure if I should set review to rhelmer or <a places person>.

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 247807 [details] [diff] [review]
add --enable-places to mozconfig

thanks nick! asking rhelmer for review.

Comment 8

[Dietrich Ayala (:dietrich)]

(In reply to comment #7)
> (From update of attachment 247807 [details] [diff] [review] [edit])
> thanks nick! asking rhelmer for review.
> 

hrm, actually this doesn't look like it'll work b/c this is a generic win32 firefox config, and from what i can tell will be applied to all win32 firefox tinderboxes. I don't know how the build team customizes these for specific tinderboxes... rhelmer, is that done on the tbox itself? or are configs for specific hosts stored somewhere else?

Comment 9

[Robert Helmer [:rhelmer]]

(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 247807 [details] [diff] [review] [edit] [edit])
> > thanks nick! asking rhelmer for review.
> > 
> 
> hrm, actually this doesn't look like it'll work b/c this is a generic win32
> firefox config, and from what i can tell will be applied to all win32 firefox
> tinderboxes. I don't know how the build team customizes these for specific
> tinderboxes... rhelmer, is that done on the tbox itself? or are configs for
> specific hosts stored somewhere else?
> 

We use different branches in CVS, default is the same as our standard branches (e.g. MOZILLA_1_8_BRANCH) but if there is a deviation we make a special minibranch.

The features minibranch for trunk is "feature_places". If we need to do something similar for the branches, it would be MOZILLA_1_8_BRANCH_feature_places (for example).

Comment 10

[Robert Helmer [:rhelmer]]

Comment on attachment 247807 [details] [diff] [review]
add --enable-places to mozconfig

actually, this needs to be a patch against the feature_places branch.

Comment 11

[Robert Helmer [:rhelmer]]

Comment on attachment 247807 [details] [diff] [review]
add --enable-places to mozconfig

actually, this is fine; feature_places branch just hasn't been checked into yet.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Checking in mozconfig;
/cvsroot/mozilla/tools/tinderbox-configs/firefox/win32/mozconfig,v  <--  mozconfig
new revision: 1.2.2.1; previous revision: 1.2
done

Comment 13

[Dietrich Ayala (:dietrich)]

will fxexp-win32-tbox automatically pull this config now? is there anything else that needs to be done to fix this?

Comment 14

[Robert Helmer [:rhelmer]]

(In reply to comment #13)
> will fxexp-win32-tbox automatically pull this config now? is there anything
> else that needs to be done to fix this?

All of the tinderboxes pull from public CVS to get their configs now, so it should just start working. It's publishing here:
http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaExperimental

Marking as fixed, please reopen or mark as verified (depending on whether it works or not)

Comment 15

[Dietrich Ayala (:dietrich)]

Thanks Rob. For the builds here:

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fxexp-win32-tbox-trunk

How can we tell which are the places builds, vs the others building on that host? Do all the tinderboxes building on that host continually overwrite in that dir?

Comment 16

[Robert Helmer [:rhelmer]]

(In reply to comment #15)
> Thanks Rob. For the builds here:
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fxexp-win32-tbox-trunk
> 
> How can we tell which are the places builds, vs the others building on that
> host? Do all the tinderboxes building on that host continually overwrite in
> that dir?

Hm, good point. For nightly (clobber) builds they go to different places, but the hourly builds probably shouldn't clobber eachother. I'll open a bug for that, thanks!