Make feed sniffing one pass

RESOLVED INACTIVE

Status

()

Firefox
RSS Discovery and Preview
RESOLVED INACTIVE
12 years ago
2 months ago

People

(Reporter: philor, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

12 years ago
In bug 337184, Darin suggested that rather than the current up to three calls to FindInReadable() on the whole first 512 bytes that we do by calling ContainsTopLevelSubstring() separately for each trigger string, we should just run through once: "just search for '<' characters, and if found, inspect the following character.  if it looks like a PI or comment, skip ahead to the next '<'.  if that looks like a tag, then compare it against our set of 'feed' tags.  done."

It's not quite that simple, since if it looks like a PI or comment, we need to skip ahead to the next '<' which comes after the matching '>' for the PI or comment, to skip triggers in comments, but as long as that's fast enough, we should be able to bail out faster in the most common case, as soon as we hit <html.
This refers to FeedSniffer.cpp

Comment 2

2 months ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.