356133 - Incorrect uneval for ({'' setter: function(){}})

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Split from bug 356083 per crowder -- decompilation of object literals within functions and uneval of objects use completely separate code.

js> o = ({'' setter: function(){}})
[object Object]

js> c = uneval(o)
({set ''() {}})

js> eval(c)
typein:7: SyntaxError: missing : after property id:
typein:7: ({set ''() {}})
typein:7: ......^

Comment 1

[Brian Crowder]

I think the bug here is that o = ({'' setter: function() {}}) works, but please correct me if I am wrong.

Comment 2

[Brendan Eich [:brendan]]

The old setter: syntax (getter:) allows any property id (non-lexical-identifier ids must of course be quoted).  That includes the empty string.  This should still work, so the decompiler should simply produce the old syntax with proper quotes where needed.

/be

Comment 3

[Brian Crowder]

I actually changed my mind about this; I'd like to handle toSource/Decompiler bugs together for cases like this, because I think a future maintainer will be less confused by seeing these changes/fixed go together.  Look at 356083 for the patch coming soon.

Comment 4

[Jesse Ruderman]

WFM, probably fixed by one of Crowder's patches.

Comment 5

[Bob Clary [:bc] (inactive)]

added test as part of js1_5/decompilation/regress-356083.js

Comment 6

[Brian Crowder]

This is specifically fixed by the patch in bug 356083 (as I mentioned here, I rolled the fixes into one patch.  Thanks for the reminder, Jesse

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0 linux/mac* 2007-05-05