356219 - window.minimize(), window.maximize() and window.restore() are not implemented in cocoa widget

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Asaf Romano (gone)]

window.minimize(), window.maximize() and window.restore() are not implemented in cocoa widget.

Comment 1

[Josh Aas]

Attachment: fix v1.0

This seems to do the trick.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 241983 [details] [diff] [review]
fix v1.0

>Index: nsCocoaWindow.mm
>===================================================================


>-// zoom/restore
>-//
> NS_METHOD nsCocoaWindow::SetSizeMode(PRInt32 aMode)
> {

Note bug 278777 somewhere here.

>+  PRInt32 previousMode;
>+  nsBaseWidget::GetSizeMode(&previousMode);
>+
>+  if (!mWindow || NS_FAILED(nsBaseWidget::SetSizeMode(aMode)))
>+    return NS_ERROR_FAILURE;
>+

(!mWindow) cannot really happen, please make this
>+  nsresult rv = nsBaseWidget::SetSizeMode(aMode);
>+  NS_ENSURE_SUCCESS(rv, rv);
    

>+  if (aMode == nsSizeMode_Normal) {
>+    if ((previousMode == nsSizeMode_Maximized) && [mWindow isZoomed])

nit: get rid of the extra parentheses.

r=mano otherwsie.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 241983 [details] [diff] [review]
fix v1.0

rs=pink

Comment 4

[Josh Aas]

landed on trunk