356221 - mozilla/he/toolkit/chrome/mozapps/update/updates.properties is missing some strings

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[(not reading, please use [e-mail] instead)]

mozilla/he/toolkit/chrome/mozapps/update/updates.properties is missing some
strings

see bug #329729 (comments #181 and #182 for more details)

Comment 1

[(not reading, please use [e-mail] instead)]

here are the strings that I plan on adding to the MOZILLA_1_8_0_BRANCH to
mozilla/he/toolkit/chrome/mozapps/update/updates.properties as part of the fix
for bug #329729

introType_minor_app=An update for %S is available:
introType_major_app_and_version=You can download and install %S %S now!
licenseContentNotFound=The license file for this version could not be found.
Please visit the %S homepage for more information.
updateMoreInfoContentNotFound=Additional details about this version could not
be found. Please visit the %S homepage for more information.
licenseContentDownloading=Getting license for %S %S...
updateMoreInfoContentDownloading=Getting more details about %S %S...
updatesfound_minor.title=Update Available
updatesfound_major.title=New Version Available
downloadButton_minor=Download & Install Now »
downloadButton_major=Get the new version »
neverButton=Never

note, I've added them in english, per axel.

also note, there are more strings missing from updates.properties and
updates.dtd on the trunk and MOZILLA_1_8_BRANCH for this locale

Comment 2

[Tomer Cohen :tomer]

Attachment: Hebrew update.properties

Reuven (linxspider) uploaded today the he translation for Firefox 2 including toolkit to the CVS server. The relevant file is being attached to this comment.

Comment 3

[(not reading, please use [e-mail] instead)]

question for tomer, linxspider and/or axel:

why is it that http://lxr.mozilla.org/l10n/source/he/toolkit/chrome/mozapps/update/updates.properties has escaped utf8, but updates.properties (attached to this bug) does not?

Comment 4

[Tomer Cohen :tomer]

(In reply to comment #3)
> why is it that 
> has escaped utf8, but updates.properties (attached to this bug) does not?

Bug in MozillaTranslator, I guess. I did the translation inside MT and this is the file I received in the export. 

Comment 5

[Marek Stępień [:marcoos, inactive]]

There's no need to escape non-ASCII characters anymore. We support both escaped and unescaped .properties.

Comment 6

[(not reading, please use [e-mail] instead)]

> There's no need to escape non-ASCII characters anymore. We support both escaped
and unescaped .properties.

thanks for the info.  but is that true for the MOZILLA_1_8_0_BRANCH (1.5.0.x) as well as MOZILLA_1_8_BRANCH and trunk?

I've got a patch to backport strings from MOZILLA_1_8_BRANCH to MOZILLA_1_8_0_BRANCH, and some are not escaped, so I want to make sure that is not a problem.

axel, do you know?

Comment 7

[Axel Hecht [:Pike]]

(In reply to comment #6)
> thanks for the info.  but is that true for the MOZILLA_1_8_0_BRANCH (1.5.0.x)
> as well as MOZILLA_1_8_BRANCH and trunk?

Yes, it always was. We just recently changed the policy to not follow the java spec on .properties and use utf-8 encoding in general. But technically, that worked for ages.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: fix for the MOZILLA_1_8_BRANCH

Comment 9

[(not reading, please use [e-mail] instead)]

thanks for the answers, guys.

see the supplimental patch in bug #329729 that adds the 11 new strings to the MOZILLA_1_8_0_BRANCH, based on the provided updates.properties attached to this bug.

I also have it in my tree for the MOZILLA_1_8_BRANCH, seeking axel's review (for 2.0.x?)

Comment 10

[Tsahi Asher]

there is a spelling errors at
licenseContentNotFound = קובץ הרישיון עבור גירסה זו לא נמצא. בבקשה כנס לדף הבית של %S למידע נוסף.

there should be a He at כנס. same in updateMoreInfoContentNotFound

also, if you write רישיון here, then you should be consistent and use the same spelling at license404Error and downloadingLicense.

in
introType_minor = זמין עדכון אבטחה חשוב עבור %S:
+introType_major = זמינה גרסה חדשה של %S:
+introType_minor_app = עדכון עבור %S זמין:

i rather not to start the sentence with a verb, and instead put the זמין at the end.

Comment 11

[Tomer Cohen :tomer]

Attachment: updated update.properties according to Tsahi notes.

Comment 12

[(not reading, please use [e-mail] instead)]

thanks for the updated version.  I'll attach a new version for this bug, and for bug #329729

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: updated fix for the MOZILLA_1_8_BRANCH, per updated updates.properties (thanks tsahi)

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 242436 [details] [diff] [review]
updated fix for the MOZILLA_1_8_BRANCH, per updated updates.properties (thanks tsahi)

I can't really tell if that's it.

Comment 15

[(not reading, please use [e-mail] instead)]

note, the new strings have made it to the MOZILLA_1_8_0_BRANCH, but have not made it to the trunk or the MOZILLA_1_8_BRANCH yet.