356232 - neverButton=AldrigNever should be neverButton=Aldrig in updates.properties

Status: RESOLVED FIXED

(Mozilla Localizations :: da / Danish, defect)

Description

[(not reading, please use [e-mail] instead)]

neverButton=AldrigNever should be neverButton=Aldrig in updates.properties

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 2

[Søren Munk Skrøder (extended hiatus)]

I verify that this indeed is a mistranslation

Comment 3

[(not reading, please use [e-mail] instead)]

note, the fix has landed on the MOZILLA_1_8_0_BRANCH, but has not made it to the trunk or to the MOZILLA_1_8_BRANCH yet.

Comment 4

[Axel Hecht [:Pike]]

Seth, you marked this fixed1.8.0.8, but I don't see a check-in?

Comment 5

[(not reading, please use [e-mail] instead)]

axel, you checked this change in for me on the MOZILLA_1_8_0_BRANCH, as part of the checkin for https://bugzilla.mozilla.org/show_bug.cgi?id=329729#c202

For evidence, see http://lxr.mozilla.org/l10n-mozilla1.8.0/source/da/toolkit/chrome/mozapps/update/updates.properties#60

I have this fix staged locally for 2.0.0.1, and when the tree opens for that I can  request r/a.

Additionally, we should fix this on the trunk.  Can you check it in there?

Comment 6

[(not reading, please use [e-mail] instead)]

proof that the trunk needs this fix as well:

http://lxr.mozilla.org/l10n/source/da/toolkit/chrome/mozapps/update/updates.properties#60

Comment 7

[Axel Hecht [:Pike]]

Ah, right, sorry, Seth.

As for the trunk check-in, I'll leave that up to Søren, so that he can do that as part of his branch/trunk work.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 241893 [details] [diff] [review]
patch

Carrying over r+ from irc.

Comment 9

[Phil Ringnalda (:philor)]

Apparently having this assigned to nobody@ hasn't worked out too well, it seems to have missed 2.0.0.1. Who should have gotten it assigned to them, and what flags should they be twiddling to catch 2.0.0.2 or 2.0.0.3?

Comment 10

[(not reading, please use [e-mail] instead)]

phil, good eye.  it made it into the fx 1.5.0.x branch, but not fx 2.0.0.x or trunk.

Søren or Axel, can you check in the change to trunk and MOZILLA_1_8_BRANCH?

I'm going to re-assign that to axel, and if he'd rather have Søren do it, he can re-assign.

(note, I don't think I have checking access for the l10n repository.)

Comment 11

[Axel Hecht [:Pike]]

Over to another Søren, though I don't really mind which Søren checks that in.

Please request approval-1.8.1.3 once that opens.

Comment 12

[Søren Munk Skrøder (extended hiatus)]

Axel

I'm in Nyborg at my mother's for the rest of the month, cramming for exams, and haven't brought my ssh keys with me...
I've made a note on the localization teams wiki, that i'm AWOL until the end of january...

As for Catch22 (the other Søren) - last i heard from him, he was swamped with work from his new employer and was considering resigning from his Mozilla affairs...
I'm considering stepping up as firefox owner, when i get back

Is is possible to get you to check the patch in??...

Comment 13

[Axel Hecht [:Pike]]

Let's push this out to 2.0.0.3 then for real, we should have at least someone from the community being able to test and verify the landed patch.

Comment 14

[Søren Munk Skrøder (extended hiatus)]

I think it's high time to get this fixed ;-D

Since Axel has already '+'ed the review, i take it as approval for checkin

Landed on 1_8_BRANCH :
Checking in updates.properties;
/l10n/l10n/da/toolkit/chrome/mozapps/update/updates.properties,v  <--  updates.properties
new revision: 1.1.2.9; previous revision: 1.1.2.8

Landed on TRUNK :
Checking in updates.properties;
/l10n/l10n/da/toolkit/chrome/mozapps/update/updates.properties,v  <--  updates.properties
new revision: 1.6; previous revision: 1.5

Resolving bug fixed...

Comment 15

[Daniel Veditz [:dveditz]]

Judging from the timing of comment 14 that this was fixed in 2.0.0.4