356248 - Incorrect decompilation for object literal with named getter function; property and function names are mashed together

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Split from bug 356085.

js> function() { return {p setter: function y() { } } }  
function () {
    return {set py() {}};
}

Comment 1

[Brian Crowder]

Attachment: adding a space in decompilation

Still trying to sneak in the cleanup for these redundant ternaries, also, added one tiny little ' ' to the print string for get/set.

Comment 2

[Brendan Eich [:brendan]]

Is this patch still needed?

/be

Comment 3

[Brian Crowder]

Yes.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 241951 [details] [diff] [review]
adding a space in decompilation

But this always puts a space after the setter name, even if there's no intrinsic function name:

js> function() { return {p setter: function() { } } }
function () {
    return {set p () {}};
}

/be

Comment 5

[Brian Crowder]

Attachment: no extra space if the decompiled rval starts with '('

Not sure if this is really good way to determine whether the function has a name or not, at this point in the process, but it seems viable.

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 259147 [details] [diff] [review]
no extra space if the decompiled rval starts with '('

Great, r=me. Thanks,

/be

Comment 7

[Brian Crowder]

jsopcode.c:3.227

Comment 8

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_5/decompilation/regress-356248.js,v  <--  regress-356248.js
initial revision: 1.1

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0 linux/mac* 2007-05-05 shell.