Crash when calling showdependencytree.cgi with no bug ID

RESOLVED FIXED in Bugzilla 2.22

Status

()

Bugzilla
Bugzilla-General
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

2.23
Bugzilla 2.22
Bug Flags:
approval +
approval2.22 +

Details

(URL)

Attachments

(1 attachment)

650 bytes, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
All you have to do is to call showdependencytree.cgi with no parameters. You get:

Undef to trick_taint at Bugzilla/Util.pm line 67
	Bugzilla::Util::trick_taint('undef') called at Bugzilla/Bug.pm line 1293
	Bugzilla::Bug::bug_alias_to_id('undef') called at Bugzilla/Bug.pm line 1910
	Bugzilla::Bug::ValidateBugID('undef') called at /var/www/html/cvsbugzilla/showdependencytree.cgi line 53
(Assignee)

Comment 1

11 years ago
Created attachment 241990 [details] [diff] [review]
patch, v1
Assignee: general → LpSolit
Status: NEW → ASSIGNED
Attachment #241990 - Flags: review?(mkanat)

Comment 2

11 years ago
Comment on attachment 241990 [details] [diff] [review]
patch, v1

Sure, that's fine. I don't know why ValidateBugID doesn't catch that, though.
Attachment #241990 - Flags: review?(mkanat) → review+

Updated

11 years ago
Flags: approval?
Flags: approval2.22?
Flags: approval?
Flags: approval2.22?
Flags: approval2.22+
Flags: approval+
(Assignee)

Comment 3

11 years ago
tip:

Checking in showdependencytree.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencytree.cgi,v  <--  showdependencytree.cgi
new revision: 1.48; previous revision: 1.47
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

11 years ago
2.22:

Checking in showdependencytree.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencytree.cgi,v  <--  showdependencytree.cgi
new revision: 1.40.2.1; previous revision: 1.40
done
You need to log in before you can comment on or make changes to this bug.