356425 - link of libxul failed when mozstorage is enabled

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Laurent Jouanneau]

I'm working on a xulrunner application based on the trunk. Mozstorage is enabled but places is not. The compiling failed during the link of the libxul :

nsStaticXULComponents.o:(.data.rel.ro+0x13c): undefined reference to « mozStorageModule_NSGetModule(nsIComponentManager*, nsIFile*, nsIModule**)   »

Perhaps i'm wrong, but i think the bug is in toolkit/library/libxul-config.mk : 

ifdef MOZ_PLACES
STATIC_LIBS += morkreader_s

COMPONENT_LIBS += \
	storagecomps \
	places \
	$(NULL)
else
ifdef MOZ_MORK
ifdef MOZ_XUL
COMPONENT_LIBS += \
	mork \
	tkhstory \
	$(NULL)
endif
endif
endif

If places is disabled, storage component is not included, even if MOZ_STORAGE=1.

(note: if MOZ_STORAGE=, the compiler failed on the compiling of toolkit/components/satchel/src/nsFormFillController.cpp : mozIStorageService.h is unknown.

Comment 1

[Laurent Jouanneau]

Attachment: my patches on the build system for my app

These are my patches to build my own application (to do --enable-application=etna).

Comment 2

[Laurent Jouanneau]

Attachment: my mozconfig file

Comment 3

[Benjamin Smedberg]

Attachment: Fix ifdefs, rev. 1

Comment 4

[Laurent Jouanneau]

Comment on attachment 242092 [details] [diff] [review]
Fix ifdefs, rev. 1

r=[e-mail]

It's ok for me.

Comment 5

[Laurent Jouanneau]

Could someone check in this patch ? (i haven't write access on the CVS)

Benjamin ? Is it all right ?

Comment 6

[Benjamin Smedberg]

Fixed on trunk.