356515 - [docs] references for every xforms control

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[alexander :surkov (:asurkov)]

The initial work have been done in bug 347610.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: output

Comment 2

[alexander :surkov (:asurkov)]

Attachment: secret

http://developer.mozilla.org/en/docs/index.php?title=XForms:User_Interface_Elements:Secret&action=edit

Comment 3

[alexander :surkov (:asurkov)]

Attachment: textarea

http://developer.mozilla.org/en/docs/index.php?title=XForms:User_Interface_Elements:Textarea&action=edit

Comment 4

[alexander :surkov (:asurkov)]

Attachment: upload

http://developer.mozilla.org/en/docs/index.php?title=XForms:User_Interface_Elements:Upload&action=edit

Comment 5

[alexander :surkov (:asurkov)]

Attachment: range

http://developer.mozilla.org/en/docs/index.php?title=XForms:User_Interface_Elements:Range&action=edit

Comment 6

[alexander :surkov (:asurkov)]

Attachment: trigger

http://developer.mozilla.org/en/docs/index.php?title=XForms:User_Interface_Elements:Trigger&action=edit

Comment 7

[aaronr]

Attachment: output2

Same as the original file with some fixes for punctuation, spelling, and some English.

Also, "analogous widgets are <code>text node for XHTML document and <xul:description/></code>" I would suggest changing the XHTML part to have the XHTML element that is most similar (probably xhtml:span).  There really isn't a 'text node' in XHTML, is there?  Just in DOM, which is used for all XML based languages and not just XHTML.

Please verify that my other changes are ok with you.

Comment 8

[aaronr]

Attachment: secret2

pretty much the same as the original document.  I corrected some English, some spelling and some puctuation.  I also added a caution that the data that is input with the 'secret' control will be stored in the instance data exactly as the user input it and that any other xform control bound to that data will show it 'as is'.  I think a caution about that is important so that the user doesn't think some kind of encryption or other form of protection is applied to the data.

Comment 9

[aaronr]

Attachment: textarea2

just changed a few words around so that it read a little smoother.  Left pretty much everything the same.

Comment 10

[aaronr]

Attachment: upload2

corrected the title, changed some wording.

Comment 11

[aaronr]

Attachment: range2

updated some of the wording/spelling.  I still don't like the description for the 'step' attribute, but I can't think of a better way to put it.

Comment 12

[aaronr]

Attachment: trigger2

changed some wording.

Comment 13

[aaronr]

Please review the changes I made to make sure that you agree with them.  I'm fine with the documents as they are now so feel free to put them up when you are ready.

Comment 14

[alexander :surkov (:asurkov)]

(In reply to comment #13)
> Please review the changes I made to make sure that you agree with them.  I'm
> fine with the documents as they are now so feel free to put them up when you
> are ready.
> 

Thanks for corrections. They are fine. I uploaded files.

Comment 15

[alexander :surkov (:asurkov)]

Attachment: submit

Comment 16

[alexander :surkov (:asurkov)]

(In reply to comment #7)
> Created an attachment (id=252291) [details]
> output2

> Also, "analogous widgets are <code>text node for XHTML document and
> <xul:description/></code>" I would suggest changing the XHTML part to have the
> XHTML element that is most similar (probably xhtml:span).  There really isn't a
> 'text node' in XHTML, is there?  Just in DOM, which is used for all XML based
> languages and not just XHTML.

I'm not sure, xhtml:span adds just inline layout element. AFAIK XHTML doesn't define any element, it just bring XML markup to HTML. Probably, we should ask someone else?

Comment 17

[aaronr]

(In reply to comment #16)
> (In reply to comment #7)
> > Created an attachment (id=252291) [details] [details]
> > output2
> 
> > Also, "analogous widgets are <code>text node for XHTML document and
> > <xul:description/></code>" I would suggest changing the XHTML part to have the
> > XHTML element that is most similar (probably xhtml:span).  There really isn't a
> > 'text node' in XHTML, is there?  Just in DOM, which is used for all XML based
> > languages and not just XHTML.
> 
> I'm not sure, xhtml:span adds just inline layout element. AFAIK XHTML doesn't
> define any element, it just bring XML markup to HTML. Probably, we should ask
> someone else?
> 


Doron and I couldn't think of anything better than span.  Maybe <p style="display: inline;"/>?  But span is still better.  That is what people use it for.  And that is the underlying control we use for xf:output on xhtml, so you really can't get a better element for comparison :-)

Comment 18

[alexander :surkov (:asurkov)]

(In reply to comment #17)

> Doron and I couldn't think of anything better than span.  Maybe <p
> style="display: inline;"/>?  But span is still better.  That is what people use
> it for.  And that is the underlying control we use for xf:output on xhtml, so
> you really can't get a better element for comparison :-)
> 

I changed on <xhtml:span/>

Comment 19

[aaronr]

Attachment: submit2

changed some of the wording.  I also changed the analogous widgets section for both 'button' and 'clickable text' so please double check it to make sure that you are ok with my changes.  Feel free to checkin if you are ok with my changes.

Comment 20

[alexander :surkov (:asurkov)]

(In reply to comment #19)

> changed some of the wording.  I also changed the analogous widgets section for
> both 'button' and 'clickable text' so please double check it to make sure that
> you are ok with my changes.  Feel free to checkin if you are ok with my
> changes.
> 

Thanks, in general I think I'm fine with analogous widgets. Uploaded.

Comment 21

[alexander :surkov (:asurkov)]

Attachment: select

Comment 22

[aaronr]

Attachment: select 2

changed some wording.  Corrected the title and link inside the text for 'copy'.  Please review before checkin.

Comment 23

[alexander :surkov (:asurkov)]

(In reply to comment #22)
> Created an attachment (id=258394) [details]
> select 2
> 
> changed some wording.  Corrected the title and link inside the text for 'copy'.
>  Please review before checkin.
> 

Looks fine. Uploaded.

Comment 24

[alexander :surkov (:asurkov)]

Attachment: select1

Comment 25

[alexander :surkov (:asurkov)]

Attachment: label

Comment 26

[alexander :surkov (:asurkov)]

Attachment: help

Comment 27

[alexander :surkov (:asurkov)]

Attachment: hint

Comment 28

[alexander :surkov (:asurkov)]

Attachment: alert

Comment 29

[alexander :surkov (:asurkov)]

Attachment: message

Comment 30

[aaronr]

Attachment: select1 #2

The language for your select1 documentation was really good.  I fixed up some stuff like you were using 'select' instead of 'select1' a lot (you probably took the bulk of the code from the select page, I'm guessing).  You didn't have the fact that when select1 is minimal we support both @selection="open" and xf:choices.  This file is your original file with my updates.  Ready for checkin, I think.

Comment 31

[aaronr]

Attachment: label 2

Fixed up some language.  The original content was really good.  Ready for checkin if you agree with the changes.

Comment 32

[aaronr]

Attachment: help 2

just some language changes, the original text was good.  Ready for checkin if you agree with the changes.

Comment 33

[aaronr]

Attachment: hint 2

just changed some language.  The original content was good.  Ready for checkin if you agree with the changes.

Comment 34

[aaronr]

Attachment: alert 2

just changed some language, the original content was good.  Ready for checkin if you agree with the changes.

Comment 35

[aaronr]

Attachment: message 2

changed some language, the original content was good.  Ready for checkin if you agree with the changes.

Comment 36

[aaronr]

(In reply to comment #32)
> Created an attachment (id=298587) [details]
> help 2
> 
> just some language changes, the original text was good.  Ready for checkin if
> you agree with the changes.
> 

Alex, you should also change "modaless" to "modeless" in the text.  I forgot to.  Thanks.

Comment 37

[alexander :surkov (:asurkov)]

(In reply to comment #30)
> Created an attachment (id=298562) [details]
> select1 #2
> 
> The language for your select1 documentation was really good.  I fixed up some
> stuff like you were using 'select' instead of 'select1' a lot (you probably
> took the bulk of the code from the select page, I'm guessing).  You didn't have
> the fact that when select1 is minimal we support both @selection="open" and
> xf:choices.  This file is your original file with my updates.  Ready for
> checkin, I think.
> 

Possibly you put my version here. I fixed select to select1 and selection="open" and checked in. Please look and do corrections if needed.

Comment 38

[alexander :surkov (:asurkov)]

(In reply to comment #31)
> Created an attachment (id=298580) [details]
> label 2
> 
> Fixed up some language.  The original content was really good.  Ready for
> checkin if you agree with the changes.
> 

checked in

Comment 39

[alexander :surkov (:asurkov)]

(In reply to comment #32)
> Created an attachment (id=298587) [details]
> help 2
> 
> just some language changes, the original text was good.  Ready for checkin if
> you agree with the changes.
> 

checked in with modeless

Comment 40

[alexander :surkov (:asurkov)]

(In reply to comment #33)
> Created an attachment (id=298588) [details]
> hint 2
> 
> just changed some language.  The original content was good.  Ready for checkin
> if you agree with the changes.
> 

checked in as is

Comment 41

[alexander :surkov (:asurkov)]

(In reply to comment #34)
> Created an attachment (id=298590) [details]
> alert 2
> 
> just changed some language, the original content was good.  Ready for checkin
> if you agree with the changes.
> 

checked in as is

Comment 42

[alexander :surkov (:asurkov)]

(In reply to comment #35)
> Created an attachment (id=298591) [details]
> message 2
> 
> changed some language, the original content was good.  Ready for checkin if you
> agree with the changes.
> 

checked in as is

Comment 43

[alexander :surkov (:asurkov)]

Attachment: group

Comment 44

[aaronr]

Attachment: group 2

just a small language change.  Ready for upload if you are ok with the change.

Comment 45

[alexander :surkov (:asurkov)]

Attachment: switch

Comment 46

[alexander :surkov (:asurkov)]

Attachment: repeat

Comment 47

[aaronr]

Attachment: switch 2

changed some language, the original content was good.  Ready for checkin if you
agree with the changes.

Comment 48

[aaronr]

Attachment: repeat 2

Changed some of the language though the initial content was good.  Please checkin if you agree with the changes.

Comment 49

[alexander :surkov (:asurkov)]

I put the switch and repeat on wiki. Thanks for review.  I'm happy we have complete documentation for our implementation of XForms controls.

Comment 50

[aaronr]

Thanks for the hard work Alex!  We owe all of our good documentation to you!