356521 - Cocoafox helper app filepicker disables all files

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Phil Ringnalda (:philor)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a1) Gecko/20061011 Firefox/3.0a1 ID:2006101121

Looks like the filter in the filepicker when you choose an application to open an unknown content type is filtering a little too hard: everything is greyed out.

STR:

1. Load http://philringnalda.com/mtests/handlergone/hard.cheese
2. In the unknown content type dialog, select "Open with" and click "Choose"
3. Try to find something which isn't grey and unselectable, and fail

Comment 1

[Josh Aas]

hwaara - might this have something to do with your recent filepicker filter patch?

Comment 2

[Phil Ringnalda (:philor)]

Nope, Håkan must be off the hook, since it's the same in 20061001 as it is today.

(Just so I don't have to look it up again, "recent filepicker filter patch" is bug 355894)

Comment 3

[Phil Ringnalda (:philor)]

*** Bug 360958 has been marked as a duplicate of this bug. ***

Comment 4

[Josh Aas]

My build from 9/27 works and my build from 9/29 doesn't. There were a lot of checkins during that time, but the only suspicious one is bug 333023.

Comment 5

[Josh Aas]

The problem may be that we're dealing with that menu in the unknown content type dialog incorrectly because you can see that even in FF 2 the menu is messed up if you try to open it. Neil's cleanup to that menu xul code might have made that mishandling of the menu not work any more and thus we don't see the option in the menu.

Comment 6

[Håkan Waara]

The problem is that our filepicker doesn't deal with the "apps" filter; there's no way to show only app bundles. 

AFAICS, bug 333023 shouldn't affect this since we're not dealing with a menu, but the "Open file" dialog...

Comment 7

[Håkan Waara]

Attachment: Fix v1

* OK, this makes the filepicker understand the magic "..apps" filter that the basefilepicker sends down to us.

* As an added bonus, I made us go to the Applications directory in this case (if there's no other dir already preset).

A few related fixes while I'm in the filepicker:

* the "Select Folder..." dialog shouldn't treat bundles as folders (because they're not; just technically)

* Correct some comments that were inaccurate

Comment 8

[Josh Aas]

That isn't the bug that I was looking at, my bad but the bug I was looking at still exists. I was looking at the fact that when you get the unknown content type dialog up there are no options in the "Open with" popup menu. Secondarily that popup menu doesn't behave correctly even when there is an option. I'll file a different bug on that.

Comment 9

[Josh Aas]

Comment on attachment 245835 [details] [diff] [review]
Fix v1

+// most this work could be done in the nib instead, and just swap the title and items dynamically.

I don't want to do anything in the nib file that we don't have to. The only reason we have one in the first place is because we have no other way to deal with the application menu. Doing it with a nib makes it harder for others to hack on, it is less transparent and we'd ultimately like to get rid of the nib file.

Comment 10

[Håkan Waara]

Thanks for the review Josh. I'll check-in without the nib comment.

Comment 11

[Håkan Waara]

Checked in.