35661 - Deleted messages come back after Get New Messages occur

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[lchiang]

Deleted messages come back after Get New Messages occur

Win32 2000-04-10-09-m15 builds.  Also have gotten reports this is occuring to 
other people.

1) Start Mail (IMAP) 
2) Multiple select messages in the Inbox
3) Delete
4) The next message never loads.  You'll see "loading document" in the status.
5) The next time a get message operation occurs, the messages you 
selected/deleted come back.

Comment 1

[lchiang]

Oops - ignore my "the next message never loads" statement in step 4.  It seems 
that the status bar gets stuck at "loading document" and then I interrupt that 
and then the next time the deleted messages come back.

Comment 2

[Scott MacGregor]

cc'ing jefft.....i've been seeing this for a couple days at least...did david or
jeff change delete recently? I don't think so...hmmm..

Comment 3

[David :Bienvenu]

No, it doesn't have to do with delete per se. As I mentioned in a private e-mail,

What's happening is that the load group is interrupting the imap session when we run
the url to fetch the message to display after deleting the messages (problem
#1). This interrupts the mock channel. When the mock
channel gets interrupted, we don't gracefully log out of the imap connection
(problem #2). This causes us to have two simultaneous
connections to the same folder. The second connection does not know about the
changes made to the first connection (e.g., the
deletes) so your deleted messages come back to life.

My guess is that either the doc shell loading stuff changed to interrupt us, or
our load group handling for imap is incorrect. But I don't
know what has changed in that area.

Comment 4

[Scott MacGregor]

I think we are getting into trouble because loading the url for displaying the
next message is causing the docshell to cancel urls it is currently loading. And
it's currently loading the message for the last selected message in your
multi-select case. And as David pointed out we aren't handling this condition
cleanly which causes another connection to get conjured up....

Comment 5

[Scott MacGregor]

the JS in the front end is asking us to load the next message twice...

i.e. it's calling open message twice in the multi-delete case. so we are
interrupting the first load and our interruption isn't cleanly working..=(

I'm going to try to figure out why the FE is suddenly telling us to load the
same message back to back like it is.....

Comment 6

[David :Bienvenu]

adding scott to cc list.

Comment 7

[Scott MacGregor]

I have a fix for this in commandglue.js. During a multi-select delete, we remove
elements from the view one by one (the view being RDF). When we only have one
selection left, we were automatically trying to load that selection in the
message pane even though we'd turn around and load another message (the next
message because that one was getting deleted).

This was causing us to load two messages per multi-select delete. So there
should be a little performance win in here too.

Of course this also means that the imap protocol is no longer working well when
interrupted via a cancel call on the channel. This bears further investigation.

Comment 8

[Scott MacGregor]

fixed

Comment 9

[laurel]

I'm seeing this happen with sequential deletes in IMAP in today's M16 commercial
builds on NT 4.0 and Mac OS 9.0.  I did not make a multiple selection, but
rather deleted 7 or 8 messages in sequence (and not real quickly either).  Then
the messages reappeared and the barber pole stayed in loading document state.

Comment 10

[esther]

Using builds 2000-05-17 on win98, mac and linux this is fixed.  I deleted a 
about 20 multiple selected msgs in one session, all messages were deleted and 
newly selected message was displayed in message pane.  Verified.