356611 - [Mac] software update button cut off for tr-TR locale

Status: RESOLVED FIXED

(Mozilla Localizations :: tr / Turkish, defect)

Description

[Marcia Knous [:marcia]]

Seen testing this RC3 candidate build: ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2.0rc3-candidates/rc1/firefox-2.0.tr.mac.dmg

Screenshot coming.

Comment 1

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue

Comment 2

[Ahmet Serkan Tıratacı]

Marcia, we found the file to be modified to fix this: updates.dtd [1] However, we want to reproduce this, so that we can create the right patch. Can you please tell us the steps to reproduce?

[1] http://lxr.mozilla.org/l10n-mozilla1.8/source/tr/toolkit/chrome/mozapps/update/updates.dtd#5

Comment 3

[Ahmet Serkan Tıratacı]

Axel, do you think that this's worth to be fixed in Firefox 2? If it's too late, we can solve this for Firefox 2.0.x.

Comment 4

[Marcia Knous [:marcia]]

Ahment: I am not sure of the exact STR because I was test regular software updates and purposely failing the update. Because I can't read turkish I don;t know what that screen actually says.

For normal software update testing, we change the pref to the test channel (betatest or releasetest) and then manually check for updates. When the update is found, we apply it and then restart Firefox. For testing failed updates, we download the update and then go in manually and change the status file from "pending" to "failed."

IMO this is not a huge issue. I do see buttons cut off more on the Macs on the l10n builds. I think this could wait until post 2.0 to fix.

Comment 5

[Ahmet Serkan Tıratacı]

It says the update has been downloaded and will take effect when Firefox restarts.

Anyway, I also think that this's not a major issue and can be fixed after Firefox 2 is released.

Comment 6

[Axel Hecht [:Pike]]

Yeah...

Comment 7

[Ahmet Serkan Tıratacı]

Attachment: patch to fix this issue

Created for reference. To be reviewed after Fx2 release.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 242487 [details] [diff] [review]
patch to fix this issue

Please land this fix now, and use the fixed1.8.1.1 and verified1.8.1.1 keywords to protocol your landing and testing progress.

Comment 9

[Ahmet Serkan Tıratacı]

Patch checked-in. Marking FIXED.

We can't verify this as this's a typographic change on an update window. But the changed file is OK.

Comment 10

[Axel Hecht [:Pike]]

[mass-verified1.8.1.1 message, filter on this if you need to]

This bug has an approved patch, but not the verified1.8.1.1 keyword.

Please make sure that the approved patch is landed (add the fixed1.8.1.1 keyword then) and tested. If you verified that the bug in question is indeed fixed on the 1.8 branch nightlies, please add the verified1.8.1.1 keyword.

We need to get the QA activities around Firefox 2.0.0.1 up to speed so that we can feel good about releasing this update.

Comment 11

[Ahmet Serkan Tıratacı]

As I said in comment #9, we can't directly verify this, as bug appeared on a window that is displayed after an update is downloaded and verified. Since we don't know of an update test channel, we can't perform such an update test and see it directly on the screen.

Comment 12

[Axel Hecht [:Pike]]

This seems to be the successful update path.

http://lxr.mozilla.org/mozilla1.8/source/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd#67 is the link to the corresponding English strings, 
"The update was successfully downloaded and verified, and it will be installed the next time &brandShortName; starts."

I don't really see a way to test that, unless we have an RC2 for 2.0.0.1 and an update. Or would RC 1 work? On a hacked build, i.e., one with the langpack replaced, the incremental update would fail, but with the following full update, we should probably see the dialog.

Marcia, does that sound right to you?

Comment 13

[Ahmet Serkan Tıratacı]

(In reply to comment #12)
> This seems to be the successful update path.
> 
> http://lxr.mozilla.org/mozilla1.8/source/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd#67
> is the link to the corresponding English strings, 
> "The update was successfully downloaded and verified, and it will be installed
> the next time &brandShortName; starts."

Yes, it's the successful update path.

> I don't really see a way to test that, unless we have an RC2 for 2.0.0.1 and an
> update. Or would RC 1 work? On a hacked build, i.e., one with the langpack
> replaced, the incremental update would fail, but with the following full
> update, we should probably see the dialog.
> 
> Marcia, does that sound right to you?
> 

Before we created the patch, we had tested the new window size through a hacked build of Firefox 1.5.0.x -> a newer Firefox 1.5.0.x and it looked OK. This's how we decided on the new window size. I guess there hasn't been a significant change on that window since Firefox 1.5, and it should be fine for Firefox 2.0.0.x too.