Closed
Bug 356618
Opened 18 years ago
Closed 18 years ago
Storage tests fail to link to xpcom ( move to TOOL_DIRS )
Categories
(Toolkit :: Storage, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
(Keywords: verified1.8.1.1)
Attachments
(1 file)
|
461 bytes,
patch
|
benjamin
:
first-review+
mconnor
:
approval1.8.1-
dveditz
:
approval1.8.1.1+
|
Details | Diff | Splinter Review |
storage/Makefile.in adds test to DIRS instead of TOOL_DIRS when tests are enabled, which means it gets build before libxpcom gets made and it fails to link. The trunk got this change, never made it to the branch.
|
Assignee | |
Comment 1•18 years ago
|
||
|
||
Comment 2•18 years ago
|
||
Comment on attachment 242242 [details] [diff] [review] TOOL_DIRS not DIRS This is safe for whenever the branch can accept it.
Attachment #242242 -
Flags: first-review?
Attachment #242242 -
Flags: first-review+
Attachment #242242 -
Flags: approval1.8.1?
Attachment #242242 -
Flags: approval1.8.1.1?
|
||
Comment 3•18 years ago
|
||
Comment on attachment 242242 [details] [diff] [review] TOOL_DIRS not DIRS Since this is part of the build, going to hold off until after 1.8.1
Attachment #242242 -
Flags: approval1.8.1? → approval1.8.1-
|
||
Comment 4•18 years ago
|
||
Comment on attachment 242242 [details] [diff] [review] TOOL_DIRS not DIRS approved for 1.8 branch (test build, not part of product), a=dveditz for drivers
Attachment #242242 -
Flags: approval1.8.1.1? → approval1.8.1.1+
|
|
||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1.1
|
|
||
Updated•18 years ago
|
Keywords: fixed1.8.1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•