Closed Bug 356637 Opened 13 years ago Closed 13 years ago

Lightning's preference tab icon is ugly

Categories

(Calendar :: Lightning Only, defect, trivial)

Lightning 0.3
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Lightning 0.5

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(2 files)

We're still using this ancient dayplanner icon for Lightning in the Tb preferences:
http://lxr.mozilla.org/mozilla/source/calendar/resources/skin/classic/calendartoolbar.png

Now that we've added the theme-specific icons for use in the alarm-slider/imip-bar/add-ons-manager, we should use it here and cvs rm the ancient crap.
Attached image pretty icon picture
Assignee: nobody → lilmatt
Status: NEW → ASSIGNED
Relevant search for use of calendartoolbar[_small].png:
http://lxr.mozilla.org/mozilla/search?string=calendartoolbar

It's referenced in calendar-button.css, but calendar-button.css isn't used anywhere. We'll delete that too.
http://lxr.mozilla.org/mozilla/search?string=calendar-button.css

Yay for cleanup and file removal!
Attachment #242255 - Flags: second-review?(dmose)
Attachment #242255 - Flags: first-review?(cmtalbert)
Comment on attachment 242255 [details] [diff] [review]
Removes ugly icon and its references, and switches to the pretty one

I like pretty icons.

Patch looks good.
Attachment #242255 - Flags: first-review?(cmtalbert) → first-review+
Comment on attachment 242255 [details] [diff] [review]
Removes ugly icon and its references, and switches to the pretty one

jminta likes patches with more minus lines than plus...
Attachment #242255 - Flags: second-review?(dmose) → second-review?(jminta)
Attachment #242255 - Flags: ui-review?(dmose)
Comment on attachment 242255 [details] [diff] [review]
Removes ugly icon and its references, and switches to the pretty one

r2=jminta, although i prefer the current icon.  I'll leave that up to dmose.
Attachment #242255 - Flags: second-review?(jminta) → second-review+
Comment on attachment 242255 [details] [diff] [review]
Removes ugly icon and its references, and switches to the pretty one

ui-r=dmose via phone
Attachment #242255 - Flags: ui-review?(dmose) → ui-review+
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.