Closed Bug 356673 Opened 13 years ago Closed 13 years ago

Optimisation of l10n files

Categories

(Firefox :: General, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 3 alpha5

People

(Reporter: hendrik, Assigned: hendrik)

Details

Attachments

(1 file, 1 obsolete file)

During translation, I stumble on small inconsistencies in the en-US files.  Things like missing endlines at the end of the file, confusing comments, strangely arranged groups of strings.  I attach a patch which solves some of these.

Not sure whether this is the right place to file this, please point me elsewhere if needed.
Attached patch The cruft mentioned above (obsolete) — Splinter Review
I just realise this is almost the same as bug 316302.  Maybe I should reopen that one and hang the attachment there?

I assigned the bug to myself, but I have no commit rights, so somebody else would have to check in.  Can somebody please set the correct review?= flag?
Assignee: nobody → hendrik.maryns
Status: NEW → ASSIGNED
Attachment #242284 - Flags: review?
Comment on attachment 242284 [details] [diff] [review]
The cruft mentioned above

Filing a new bug was the right thing to do.
Attachment #242284 - Flags: review? → review?(mconnor)
Comment on attachment 242284 [details] [diff] [review]
The cruft mentioned above

Doesn't look like mconnor will get to this. Gavin to the rescue?
Attachment #242284 - Flags: review?(mconnor) → review?(gavin.sharp)
Attached patch tweaked patchSplinter Review
I replaced some tabs with spaces and did a bit of extra cleanup.
Attachment #242284 - Attachment is obsolete: true
Attachment #263484 - Flags: review+
Attachment #242284 - Flags: review?(gavin.sharp)
mozilla/toolkit/locales/en-US/chrome/global/charsetOverlay.dtd 	1.3
mozilla/toolkit/locales/en-US/chrome/global/commonDialog.dtd 	1.3
mozilla/toolkit/locales/en-US/chrome/global/customizeCharset.dtd 	1.6
mozilla/toolkit/locales/en-US/chrome/global/customizeToolbar.dtd 	1.4
mozilla/toolkit/locales/en-US/chrome/global/dialogOverlay.dtd 	1.4
mozilla/toolkit/locales/en-US/chrome/global/nsHelperAppDlg.dtd 	1.6
mozilla/toolkit/locales/en-US/chrome/global/nsProgressDialog.properties 	1.5
mozilla/toolkit/locales/en-US/chrome/global/printProgress.dtd 	1.3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha5
You need to log in before you can comment on or make changes to this bug.