356673 - Optimisation of l10n files

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Hendrik Maryns]

During translation, I stumble on small inconsistencies in the en-US files.  Things like missing endlines at the end of the file, confusing comments, strangely arranged groups of strings.  I attach a patch which solves some of these.

Not sure whether this is the right place to file this, please point me elsewhere if needed.

Comment 1

[Hendrik Maryns]

Attachment: The cruft mentioned above

I just realise this is almost the same as bug 316302.  Maybe I should reopen that one and hang the attachment there?

I assigned the bug to myself, but I have no commit rights, so somebody else would have to check in.  Can somebody please set the correct review?= flag?

Comment 2

[Nickolay_Ponomarev]

Comment on attachment 242284 [details] [diff] [review]
The cruft mentioned above

Filing a new bug was the right thing to do.

Comment 3

[Nickolay_Ponomarev]

Comment on attachment 242284 [details] [diff] [review]
The cruft mentioned above

Doesn't look like mconnor will get to this. Gavin to the rescue?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: tweaked patch

I replaced some tabs with spaces and did a bit of extra cleanup.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/locales/en-US/chrome/global/charsetOverlay.dtd 	1.3
mozilla/toolkit/locales/en-US/chrome/global/commonDialog.dtd 	1.3
mozilla/toolkit/locales/en-US/chrome/global/customizeCharset.dtd 	1.6
mozilla/toolkit/locales/en-US/chrome/global/customizeToolbar.dtd 	1.4
mozilla/toolkit/locales/en-US/chrome/global/dialogOverlay.dtd 	1.4
mozilla/toolkit/locales/en-US/chrome/global/nsHelperAppDlg.dtd 	1.6
mozilla/toolkit/locales/en-US/chrome/global/nsProgressDialog.properties 	1.5
mozilla/toolkit/locales/en-US/chrome/global/printProgress.dtd 	1.3