356722 - Calendar view displays without colors and no toolbar icons are shown

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Regression:
No toolbar icons shown for Lightning buttons
No icons shown in Add-ons Manager
Calendar view is displayed without styling/colors

Works in Lightning/0.4a1 2006-10-13-09-mozilla1.8
Fails in Lightning/0.4a1 2006-10-14-07-mozilla1.8

Comment 1

[Matthew (lilmatt) Willis]

Attachment: fixes jar.mn

Adds skin files to classic.jar (rather than calendar.jar).
This is where http://lxr.mozilla.org/mozilla/source/calendar/lightning/chrome.manifest
tells the app they are.

Comment 2

[Matthew (lilmatt) Willis]

Attachment: fix lightning

ssitter found that the previous fix moved the problem to Sunbird.
The problem is that Lightning expects skin files in classic.jar, while Sunbird expects them in calendar.jar

This patch changes lightning's chrome manifest to match Sunbird's behaviour: look for calendar skin files in calendar.jar, and puts lightning skin files in lightning.jar.

Comment 3

[Stefan Sitter [:ssitter]]

Comment on attachment 242329 [details] [diff] [review]
fix lightning

Yes, this fixes the calendar view and the toolbar icons. 
But now the minimonth is without styling and the icon in preference dialog is missing too.

Comment 4

[Matthew (lilmatt) Willis]

Attachment: correct patch

I had attached the wrong patch.

Try this. My apologies

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 242334 [details] [diff] [review]
correct patch

Yep, that works better. r=ssitter

Comment 6

[Matthew (lilmatt) Willis]

Comment on attachment 242334 [details] [diff] [review]
correct patch

over to dmose per jminta

Comment 7

[Matthew (lilmatt) Willis]

Patch landed on MOZILLA_1_8_BRANCH and trunk (for testday)

-> FIXED