356728 - Live.com uses Sherlock and window.sidebar.addSearchEngine for Firefox 2 builds (results in gibberish in the search box for characters not in x-mac-roman)

Status: RESOLVED INVALID

(Web Compatibility :: Site Reports, defect)

Description

[Mark Kaplun]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061003 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061003 Firefox/2.0

Using the live.com search macros I have created a "search engine" with a name in hebrew. When i used the "Add to browser search box" the "search engine" was added, but instead of displaying the hebrew name a text junk had appeared in the search box drop down list.


Reproducible: Always

Steps to Reproduce:
1. Goto the url
2. Click the "Add to browser search box" link
3. 

Actual Results:  
the new search engine name is junk text

Expected Results:  
the search engine name should be in hebrew.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The attribute used by Firefox for is the engine's "ShortName". When I load http://search.live.com/macros/markkaplun/search_hebrew/opensearch.xml in the browser (as UTF-8), the ShortName I see in the XML is the same one I see in the search bar dropdown after installing the engine, so this seems to work for me.

Can you explain what you mean by "gibberish"? Maybe a screenshot would help.

Comment 2

[Mark Kaplun]

Attachment: screenshot of the gibberish search engine entry

Comment 3

[Jackie Liu]

Works for me also in "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061014 BonEcho/2.0".

Comment 4

[Mark Kaplun]

As far as I understan the code in the page, the file being used for the S.E. definition for FF is http://search.live.com:80/macros/markkaplun-search_hebrew.src  and the xml is used by IE7.

For sure this might be a bug in the definition generated at the site.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Oh, I see the problem. The JavaScript generated by that site tries to be compatible with Firefox 1.5.0.x builds, by using the old window.sidebar.addSearchEngine method with a Sherlock file (http://search.live.com:80/macros/markkaplun-search_hebrew.src). Unfortunately Sherlock files default to x-max-roman, and the file doesn't specify a sourceTextEncoding per http://mycroft.mozdev.org/deepdocs/searchtag.html#c13 . This results in the gibberish that you see.

This bug also exists in 1.5.0.x. What Live.com should do to fix this is always use window.external.AddSearchProvider (with the OpenSearch file) if it exists, which is the case for Firefox 2 builds. Mark, do you think you could contact them and let them know about the problem?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(for anyone else trying to reproduce, you need to use the "Add to browser search box" link on the page, not the search bar's "Add engine" menuitem)

Comment 7

[Mark Kaplun]

Yes, I will do that.

Comment 8

[Karl Dubost💡 :karlcow]

http://search.live.com/macros/markkaplun/search_hebrew/?FORM=OIJG
is redirected to 
http://www.bing.com/macros/markkaplun/search_hebrew/?FORM=OIJG&fdr=lc
with the message.

> That web page doesn't exist