Closed Bug 356770 Opened 13 years ago Closed 10 years ago

Account wiz talks about 'Tools menu' where 'Edit menu' should have been used on linux

Categories

(Thunderbird :: Account Manager, defect, minor)

All
Linux
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: jshin1987, Assigned: mkmelin)

References

Details

Attachments

(1 file)

http://lxr.mozilla.org/seamonkey/source/mail/locales/en-US/chrome/messenger/AccountWizard.dtd#94
has the following: 

94 <!ENTITY haveSmtp2.suffix "&quot;, will be used. You can modify outgoing server settings by choosing Account Settings from the Tools menu.">
 

On Linux, 'Account Settings' is in 'Edit menu' rather than in 'Tools menu'. On Mac, it may be in 'Apple menu' (I'm too lazy to check it now). Perhaps, we need to add a platform-dependent entity and use it in a platform-dependent-way in xul files that refer to it.
It better not be in the Apple menu. However, it's also not in the Thunderbird menu - it's just Linux where it's not in Tools.
(In reply to comment #1)
> It better not be in the Apple menu. However, it's also not in the Thunderbird
> menu - it's just Linux where it's not in Tools.

Thanks for the clarification. I should've known better than to mistake 'Thunderbird menu' for 'Apple menu'. Anyway, an alternative would be to move 'Account settings' to Tools on Linux. I'm not sure how important it is to keep 'Preference' and 'Account settings' in the same menu. 




Severity: normal → minor
Assignee: mscott → nobody
Attached patch proposed fixSplinter Review
Avoiding talking about menus altogether. I also doubt you ever want to change the settings of the existing server, you want to change which one to use, possibly setting up an new one.

Not sure how much tb will use the old style account wiz in the end, but we might as well fix this.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #388046 - Flags: superreview?(neil)
Attachment #388046 - Flags: review?(philringnalda)
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0b4
Comment on attachment 388046 [details] [diff] [review]
proposed fix

We don't need any string text changes as such because we have no plans to stop using the Edit menu on any platform.
I can ignore changing suite/ wording if want, though the message is still off imo.
Comment on attachment 388046 [details] [diff] [review]
proposed fix

Getting clarkbw on this
Attachment #388046 - Flags: ui-review?(clarkbw)
Comment on attachment 388046 [details] [diff] [review]
proposed fix

I double-checked and I still don't see anything wrong with suite's current wording so sr=me only on syncing the name changes.
Attachment #388046 - Flags: superreview?(neil) → superreview+
Attachment #388046 - Flags: review?(philringnalda) → review+
Comment on attachment 388046 [details] [diff] [review]
proposed fix

Fine by me if it works for Bryan.
Comment on attachment 388046 [details] [diff] [review]
proposed fix

looks good, sorry for the delay
Attachment #388046 - Flags: ui-review?(clarkbw) → ui-review+
changeset:   3139:f334fa8428c5
http://hg.mozilla.org/comm-central/rev/f334fa8428c5

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: 'Tools menu' is used on linux where 'Edit menu' should be used → Account wiz talks about 'Tools menu' where 'Edit menu' should have been used on linux
Comment on attachment 388046 [details] [diff] [review]
proposed fix

>diff --git a/mail/locales/en-US/chrome/messenger/AccountWizard.dtd b/mail/locales/en-US/chrome/messenger/AccountWizard.dtd

>+<!ENTITY haveSmtp2.suffix2 "&quot;, will be used. You can the change outgoing servers in the account settings.">

There is a superfluous "the" in that last sentence.
Thx Hasse, fixed.

changeset:   3212:99a2ac5bc318
http://hg.mozilla.org/comm-central/rev/99a2ac5bc318
You need to log in before you can comment on or make changes to this bug.