356770 - Account wiz talks about 'Tools menu' where 'Edit menu' should have been used on linux

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Jungshik Shin]

http://lxr.mozilla.org/seamonkey/source/mail/locales/en-US/chrome/messenger/AccountWizard.dtd#94
has the following: 

94 <!ENTITY haveSmtp2.suffix "&quot;, will be used. You can modify outgoing server settings by choosing Account Settings from the Tools menu.">
 

On Linux, 'Account Settings' is in 'Edit menu' rather than in 'Tools menu'. On Mac, it may be in 'Apple menu' (I'm too lazy to check it now). Perhaps, we need to add a platform-dependent entity and use it in a platform-dependent-way in xul files that refer to it.

Comment 1

[Phil Ringnalda (:philor)]

It better not be in the Apple menu. However, it's also not in the Thunderbird menu - it's just Linux where it's not in Tools.

Comment 2

[Jungshik Shin]

(In reply to comment #1)
> It better not be in the Apple menu. However, it's also not in the Thunderbird
> menu - it's just Linux where it's not in Tools.

Thanks for the clarification. I should've known better than to mistake 'Thunderbird menu' for 'Apple menu'. Anyway, an alternative would be to move 'Account settings' to Tools on Linux. I'm not sure how important it is to keep 'Preference' and 'Account settings' in the same menu. 

Comment 3

[Micah Gersten]

Ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/mozilla-thunderbird/+bug/79337

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Avoiding talking about menus altogether. I also doubt you ever want to change the settings of the existing server, you want to change which one to use, possibly setting up an new one.

Not sure how much tb will use the old style account wiz in the end, but we might as well fix this.

Comment 5

[[e-mail]]

Comment on attachment 388046 [details] [diff] [review]
proposed fix

We don't need any string text changes as such because we have no plans to stop using the Edit menu on any platform.

Comment 6

[Magnus Melin [:mkmelin]]

I can ignore changing suite/ wording if want, though the message is still off imo.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 388046 [details] [diff] [review]
proposed fix

Getting clarkbw on this

Comment 8

[[e-mail]]

Comment on attachment 388046 [details] [diff] [review]
proposed fix

I double-checked and I still don't see anything wrong with suite's current wording so sr=me only on syncing the name changes.

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 388046 [details] [diff] [review]
proposed fix

Fine by me if it works for Bryan.

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 388046 [details] [diff] [review]
proposed fix

looks good, sorry for the delay

Comment 11

[Magnus Melin [:mkmelin]]

changeset:   3139:f334fa8428c5
http://hg.mozilla.org/comm-central/rev/f334fa8428c5

->FIXED

Comment 12

[u60234]

Comment on attachment 388046 [details] [diff] [review]
proposed fix

>diff --git a/mail/locales/en-US/chrome/messenger/AccountWizard.dtd b/mail/locales/en-US/chrome/messenger/AccountWizard.dtd

>+<!ENTITY haveSmtp2.suffix2 "&quot;, will be used. You can the change outgoing servers in the account settings.">

There is a superfluous "the" in that last sentence.

Comment 13

[Magnus Melin [:mkmelin]]

Thx Hasse, fixed.

changeset:   3212:99a2ac5bc318
http://hg.mozilla.org/comm-central/rev/99a2ac5bc318