356774 - border-collapse: collapse:: border disappears for very thin borders

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[esorens]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7

When the border-collapse:collapse is set for a table, tr, or td element and the border width is set to 0.1mm, the border completely disappears. Example: 

<table style="border:1mm solid black">
 <tr>
  <td>Border: 1mm, not collapsed </td>
 </tr>
</table>

<br/>

<table style="border:1mm solid black;border-collapse:collapse">
 <tr>
  <td>Border: 1mm, collapsed </td>
 </tr>
</table>

<br/>

<table style="border:0.1mm solid black">
 <tr>
  <td>Border: 0.1mm, not collapsed </td>
 </tr>
</table>

<br/>

<table style="border:0.1mm solid black;border-collapse:collapse">
 <tr>
  <td>Border: 0.1mm, collapsed (and gone!)</td>
 </tr>
</table>


Reproducible: Always

Steps to Reproduce:
1. The code above is always reproducible; a table with a mixture of collapsed borders of varying thicknesses isn't always reproducible.
2.
3.

Actual Results:  
The fourth table (in the example code) has no border.

Expected Results:  
The fourth table should have a border like the one above it.

Comment 1

[esorens]

Attachment: test case

Comment 2

[Daniel.S]

No border in Firefox 2, but borders everywhere in Firefox 3 and higher.

Comment 3

[Daniel.S]

Attachment: reftest

I had to add 1px margin to position them equally, but it should be fine otherwise.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 355150 [details] [diff] [review]
reftest

r+sr=dbaron, although I'm not sure the margin thing is really something we want to depend on; I suppose we can fix the test if we change it, though.

Comment 5

[Daniel.S]

(In reply to comment #4)
> (From update of attachment 355150 [details] [diff] [review])
> r+sr=dbaron, although I'm not sure the margin thing is really something we want
> to depend on; I suppose we can fix the test if we change it, though.

Yeah, I guess I'll keep an eye on this test for a while.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/af739efb3efa

Comment 7

[Dão Gottwald [:dao]]

This failed on OS X 10.5.2 mozilla-central unit test:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1234015866.1234021937.12312.gz

Comment 8

[Daniel.S]

Attachment: reftest for Win and Linux

(In reply to comment #7)
> This failed on OS X 10.5.2 mozilla-central unit test:

That's too bad. Since I don't own a Mac I can only offer this updated reftest that expects the test to fail on Mac.

Comment 9

[Daniel.S]

Comment on attachment 361058 [details] [diff] [review]
reftest for Win and Linux

David, do you think this is ok or should we approach this issue differently?

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: test failures

Here's the tinderbox log of the failure.

I marked the test as failing on Mac for now:
http://hg.mozilla.org/mozilla-central/rev/c15b6a0ccdd4

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the failure is a known bug, bug 379317, that causes a few other border-related reftests to fail on Mac.  I marked it as such in the manifest:
http://hg.mozilla.org/mozilla-central/rev/969124be3084
so I think we're now ok here.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

To be exact, the failure is that in the reference, the four corners are showing up as #010101 instead of #000000.  (I'm not sure why reftest-analyzer doesn't show that, though.)