Closed Bug 356801 Opened 17 years ago Closed 17 years ago

Remove unused cruft from Print Preview

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: prometeo.bugs, Assigned: prometeo.bugs)

Details

(Keywords: fixed-seamonkey1.1b)

Attachments

(1 file, 1 obsolete file)

Correct diff format, carrying over r+
5.03 KB, patch
prometeo.bugs
: review+
jag+mozilla
: superreview+
kairo
: approval-seamonkey1.1b+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text

While fixing bug 356649, I've found that the images arrow-up/dn-sharp.gif are styled in printing.css but never used (probably were removed when print preview was modified long time ago). We can safely remove the 2 gifs and their styling rules.

Reproducible: Always
Attached patch Something like this... (obsolete) — — Splinter Review 
And the two images can be cvs removed, too, I guess...
Attachment #242391 - Flags: review?(neil)
Comment on attachment 242391 [details] [diff] [review]
Something like this...

We might switch scrollboxes to use those arrows or something, so just clean up the CSS. (P.S. Don't forget cvs diff -u next time!)
Attachment #242391 - Flags: review?(neil) → review+

        Attachment #242391 -
        Attachment is obsolete: true

        Attachment #242399 -
        Flags: superreview?

        Attachment #242399 -
        Flags: review+

    
  

        Attachment #242399 -
        Flags: superreview? → superreview?(jag)

    
  

        Attachment #242399 -
        Flags: superreview?(jag) → superreview+

    
  
Whiteboard: [checkin needed]

    
    

    
  
Comment on attachment 242399 [details] [diff] [review]
Correct diff format, carrying over r+

Not sure if it's worth it, but trying nonetheless. Maybe we can save a few bytes from the binaries... ;)

        Attachment #242399 -
        Flags: approval-seamonkey1.1b?

    
  
Assignee: guifeatures → giacomo.magnini
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  
Comment on attachment 242399 [details] [diff] [review]
Correct diff format, carrying over r+

a=me for 1.1b

        Attachment #242399 -
        Flags: approval-seamonkey1.1b? → approval-seamonkey1.1b+

    
    

    
  
Checked in on trunk and branch.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed-seamonkey1.1b
Resolution: --- → FIXED
Whiteboard: [checkin needed]

    
  
Component: XP Apps: GUI Features → UI Design

          You need to log in
          before you can comment on or make changes to this bug.