Remove unused cruft from Print Preview

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Giacomo Magnini, Assigned: Giacomo Magnini)

Tracking

({fixed-seamonkey1.1b})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.03 KB, patch
Giacomo Magnini
: review+
jag (Peter Annema)
: superreview+
Robert Kaiser
: approval-seamonkey1.1b+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.8.0.7) Gecko/20060913 Fedora/1.5.0.7-1.fc5 Firefox/1.5.0.7 pango-text

While fixing bug 356649, I've found that the images arrow-up/dn-sharp.gif are styled in printing.css but never used (probably were removed when print preview was modified long time ago). We can safely remove the 2 gifs and their styling rules.

Reproducible: Always
(Assignee)

Comment 1

11 years ago
Created attachment 242391 [details] [diff] [review]
Something like this...

And the two images can be cvs removed, too, I guess...
(Assignee)

Updated

11 years ago
Attachment #242391 - Flags: review?(neil)

Comment 2

11 years ago
Comment on attachment 242391 [details] [diff] [review]
Something like this...

We might switch scrollboxes to use those arrows or something, so just clean up the CSS. (P.S. Don't forget cvs diff -u next time!)
Attachment #242391 - Flags: review?(neil) → review+
(Assignee)

Comment 3

11 years ago
Created attachment 242399 [details] [diff] [review]
Correct diff format, carrying over r+
Attachment #242391 - Attachment is obsolete: true
Attachment #242399 - Flags: superreview?
Attachment #242399 - Flags: review+
(Assignee)

Updated

11 years ago
Attachment #242399 - Flags: superreview? → superreview?(jag)

Updated

11 years ago
Attachment #242399 - Flags: superreview?(jag) → superreview+
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]
(Assignee)

Comment 4

11 years ago
Comment on attachment 242399 [details] [diff] [review]
Correct diff format, carrying over r+

Not sure if it's worth it, but trying nonetheless. Maybe we can save a few bytes from the binaries... ;)
Attachment #242399 - Flags: approval-seamonkey1.1b?

Updated

11 years ago
Assignee: guifeatures → giacomo.magnini
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 5

11 years ago
Comment on attachment 242399 [details] [diff] [review]
Correct diff format, carrying over r+

a=me for 1.1b
Attachment #242399 - Flags: approval-seamonkey1.1b? → approval-seamonkey1.1b+

Comment 6

11 years ago
Checked in on trunk and branch.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed-seamonkey1.1b
Resolution: --- → FIXED
Whiteboard: [checkin needed]

Updated

9 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.