356805 - Undo close tab doesn't turn the tab bar on

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Set the tab bar to auto hide
2. Delete all your tabs except one, so that your tab bar auto hides
3. Press Ctrl+Shift+T

Expected result: tab bar shows two tabs

Actual result: tab is undeleted but tab bar does not appear

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

            else // if there's only one tab, it's selected anyway
              this.selectedTab = t;

Hmm... why did adding this.mStrip.collapsed = false; there not work? :-\

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #1)
>             else // if there's only one tab, it's selected anyway
>               this.selectedTab = t;
> 
> Hmm... why did adding this.mStrip.collapsed = false; there not work? :-\

There was an ID-10-T error in the compile.  It shows the strip properly when it should, but it occasionally results in a gray bar below the browser, and messed up painting + boatloads of asserts + crashes on shutdown.

###!!! ASSERTION: we shouldn't still be observing the doc: 'mContentViewer && mD
ocument', file i:/smtrunk1/mozilla/docshell/shistory/src/nsSHEntry.cpp, line 718

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: seems to work

I can't reproduce the bustage I saw before, so let's see what the reviewers think.  Maybe some gecko stuff was broken when I tried this before.

Comment 4

[[e-mail]]

Comment on attachment 247137 [details] [diff] [review]
seems to work

>+              this.removeTab(this.mTabs[0]); // if there's only one tab, it's selected anyway
Nit: long line

>+            else  {
Nit: two spaces    ^