356901 - Error message, plus warnings, for valid "offset" attribute on <stop>

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See testcase in URL field.  I might end up fixing this in bug 314286...

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 255342 [details] [diff] [review]
patch

I guess, sure.  Kinda hard to tell what's going on with all the reindenting...

Comment 3

[Robert Longson [:longsonr]]

Attachment: with -w in case anyone's interested

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 255362 [details] [diff] [review]
with -w in case anyone's interested

>+  if (nsSVGElement::ParseAttribute(aNamespaceID, aAttribute, aValue, aResult))
>+    return PR_TRUE;
>+
>   return PR_FALSE;

Oh, I did have a comment on that.  Why not just:

  return nsSVGElement::ParseAttribute(aNamespaceID, aAttribute, aValue, aResult);

?

Comment 5

[Robert Longson [:longsonr]]

Attachment: update as per sr comment

Comment 6

[Robert Longson [:longsonr]]

Comment on attachment 255366 [details] [diff] [review]
update as per sr comment

checked in.