35691 - Case where reply-to causes no To: header in new message

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[laurel]

Using 2000-04-12 m15 commercial builds
Found while verifying bug #14868

If you have a reply-to address set in your identity which is used for a
news/nntp account, there is a case where this will cause no To: header in a new
message compose window.

1.  Set up a news/nntp account in your profile.  In this Identity, fill in a
reply-to address for the account in the main account settings panel.
2.  Open the mail window and select the server/account root for the news/nntp
account.  
3.  Click New Msg button.

Result:  New message window opens with Reply-to header properly filled in with
the address as specified in the Identity account settings.  However, there is no
other address header available.  User can create one.

Expected: It should give you a To: header line (blank) in addition to the
Reply-to header.  Because the server is selected instead of a newsgroup, it
would revert to To:

Comment 1

[Jean-Francois Ducarroz]

Accepting

Comment 2

[selmer (gone)]

Minor UI fixups to M18.  If this is incorrect, please adjust.

Comment 3

[sol]

Moving to future milestone, and added "polish" keyword.

Comment 4

[Jean-Francois Ducarroz]

works for me.

Comment 5

[laurel]

Still happens exactly as written using oct30 branch build. Hate to reopen, this
is a minor issue, but it is still there. Key: remember to select the SERVER, not
the newsgrouphttp://bugzilla.mozilla.org/createattachment.cgi?id=35691

Comment 6

[Håkan Waara]

yep, happens for me too when I reproduce the exact steps that laurel mentions
and selects the server. I wonder if this is backend or frontend...hmm

Comment 7

[[e-mail]]

Frontend:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailCommands.js#154
When composing a new message, the folder is checked and the message is converted
into a new post if the server type is nntp. However if the folder is the server
then this is the wrong action. It needs to check that the folder is not a server.

Comment 8

[[e-mail]]

Attachment: possible patch

Comment 9

[Jean-Francois Ducarroz]

over to varada. Varada, can you test and review the patch. Thanks

Comment 10

[Håkan Waara]

Remove the tabs.

r=hwaara

Reassign to Neil.  CC sspitzer for super-review.

Comment 11

[[e-mail]]

Attachment: Same patch with new tabs changed to 4 spaces

Comment 12

[[e-mail]]

CCing [e-mail] for sr because sspitzer hasn't after over a month.

Comment 13

[David :Bienvenu]

We're waiting for Varada to try it out.

Comment 14

[varada]

I am sorry for not noticing this in my radar, will take a look at this ASAP.

Comment 15

[varada]

Comment on attachment 46047 [details] [diff] [review]
Same patch with new tabs changed to 4 spaces

r=varada
Thanks for the patch.

Comment 16

[David :Bienvenu]

sr=bienvenu

Comment 17

[[e-mail]]

Then can someone check this in for me please?

Comment 18

[(not reading, please use [e-mail] instead)]

sorry for the delay.  I'll go apply (and make sure it still works) and then land.

Comment 19

[(not reading, please use [e-mail] instead)]

when the tree opens, I'll land this for neil.

Comment 20

[(not reading, please use [e-mail] instead)]

Comment on attachment 46047 [details] [diff] [review]
Same patch with new tabs changed to 4 spaces

sr=sspitzer

even with out this patch, this appears to have been fixed by other changes.  but his patch is still worth taking.

Comment 21

[(not reading, please use [e-mail] instead)]

fixed.

Comment 22

[laurel]

OK using nov7 commercial trunk build: win98, mac OS X, linux rh6.2