Update window title and tab label

RESOLVED FIXED in 0.1

Status

--
enhancement
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: glazou, Assigned: glazou)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

12 years ago
Update window title and tab label on document load and tab select.
(Assignee)

Updated

12 years ago
Attachment #242494 - Flags: review?(brade)

Comment 2

12 years ago
Comment on attachment 242494 [details] [diff] [review]
fix #1

I'm ok with most of the patch.  The only thing I see is that the window title and doc title could use format strings instead of hard coding this format.  Right-To-Left languages may want to reorder the components of the window title.  In the past, I've added something like "Last modified %1$S by %s$S" to the appropriate properties file.
Attachment #242494 - Flags: review?(brade) → review-
(Assignee)

Comment 3

12 years ago
Created attachment 242751 [details] [diff] [review]
fix #2 in answer to brade's comments
Attachment #242494 - Attachment is obsolete: true
Attachment #242751 - Flags: review?(brade)

Comment 4

12 years ago
Comment on attachment 242751 [details] [diff] [review]
fix #2 in answer to brade's comments

r=brade if you switch to using stringBundle.formatStringFromName() with properties that use %1$S.

In RTL languages are urls still shown LTR? (Is the scheme on the left or the right?)

Please post final patch in bug.
Attachment #242751 - Flags: review?(brade) → review+
(Assignee)

Comment 5

12 years ago
Created attachment 242843 [details] [diff] [review]
fix #3 holding r=brade
Attachment #242751 - Attachment is obsolete: true
(Assignee)

Comment 6

12 years ago
fixed and checked in (trunk) ; thanks brade!
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.