Closed Bug 357109 Opened 13 years ago Closed 13 years ago
Invalid search engine update URLs may cause an assertion dialog each time an update check occurs
This is the cause of the dialog in attachment 242608 [details]. The engine's updateURL is not a valid URI, and we don't check that before calling addEngine with it.
This makes sure we don't attempt the update if the updateURI is invalid.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #242627 - Flags: review?(mconnor)
Attachment #242627 - Flags: review?(mconnor) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 242627 [details] [diff] [review] patch This is a simple, low-risk fix to avoid update problems for plugins with malformed updateURLs.
Attachment #242627 - Flags: approval184.108.40.206?
Comment on attachment 242627 [details] [diff] [review] patch Approved for 1.8.1 branch, a=jay for drivers.
Attachment #242627 - Flags: approval220.127.116.11? → approval18.104.22.168+
Gavin (or anyone else) If you found / find any plugins hosted at Mycroft that were causing this I'd be grateful if you could let me know and I can get the update urls updated so to speak :)
You need to log in before you can comment on or make changes to this bug.