Closed Bug 357109 Opened 18 years ago Closed 18 years ago

Invalid search engine update URLs may cause an assertion dialog each time an update check occurs

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 2

People

(Reporter: Gavin, Assigned: Gavin)

Details

(Keywords: verified1.8.1.1)

Attachments

(1 file)

patch
1.72 KB, patch
mconnor
: review+
jay
: approval1.8.1.1+
Details | Diff | Splinter Review 
This is the cause of the dialog in attachment 242608 [details]. The engine's updateURL is not a valid URI, and we don't check that before calling addEngine with it.
Attached patch patch — — Splinter Review 
This makes sure we don't attempt the update if the updateURI is invalid.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #242627 - Flags: review?(mconnor)
Flags: blocking1.8.1.1?
Attachment #242627 - Flags: review?(mconnor) → review+
mozilla/browser/components/search/nsSearchService.js 	1.87
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 242627 [details] [diff] [review]
patch

This is a simple, low-risk fix to avoid update problems for plugins with malformed updateURLs.
Attachment #242627 - Flags: approval1.8.1.1?
Flags: blocking1.8.1.1? → blocking1.8.1.1-
Comment on attachment 242627 [details] [diff] [review]
patch

Approved for 1.8.1 branch, a=jay for drivers.
Attachment #242627 - Flags: approval1.8.1.1? → approval1.8.1.1+
mozilla/browser/components/search/nsSearchService.js 	1.1.2.71
Keywords: fixed1.8.1.1
Gavin (or anyone else)

If you found / find any plugins hosted at Mycroft that were causing this I'd be grateful if you could let me know and I can get the update urls updated so to speak :)
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.1 → verified1.8.1.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: