Closed Bug 357143 Opened 14 years ago Closed 13 years ago

code cleanup: use full literal of introType_major_app_and_version and introType_minor_app in updates.js

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: moco, Assigned: sciguyryan)

References

Details

Attachments

(1 file)

code cleanup:  use full literal of introType_major_app_and_version and introType_minor_app in updates.js

from dan's review of my patch in #329729


>+    if (severity == "major") {
     ...
>+        "introType_" + severity + "_app_and_version", 

This seems silly, there is only one app_and_version string and we know
severity == "major". It'd be much clearer just to use the full
literal "introType_major_app_and_version"

>+    else {
      ...
>+          "introType_" + severity + "_app", [gUpdates.brandName]);

ditto "introType_minor_app"

see http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/update/content/updates.js#670
Attached patch Patch v1Splinter Review
Patch v1.

Code changes as suggested by Seth.
Attachment #242676 - Flags: review?(sspitzer)
ryan, thanks for the patch.  

It looks good, but i'll double check by testing it out before I land it.
Assignee: sspitzer → sciguyryan+bugzilla
Comment on attachment 242676 [details] [diff] [review]
Patch v1

i've reviewed and tested this patch.

r=sspitzer

thanks ryan!
Attachment #242676 - Flags: review?(sspitzer) → review+
fixed.

Checking in updates.js;
/cvsroot/mozilla/toolkit/mozapps/update/content/updates.js,v  <--  updates.js
new revision: 1.70; previous revision: 1.69
done
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha1
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.