357243 - Can not add certain item into cookie "Exceptions" list after clicking "Remove All Sites"

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Qing Tony Hao]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1b2) Gecko/20061009 Firefox/2.0b2
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1b2) Gecko/20061009 Firefox/2.0b2

After some operations and "Remove All Sites" in the cookie "Exceptions", I can not add certain item into list again unless I dismiss Edit->Preference dialogue and invoke it again.

Reproducible: Always

Steps to Reproduce:
1.Choose Privacy tab in Edit->Preference 
2.In the Cookies section, click "Exceptions" button
3.Add www.google.com into list and set it to "Allow"
4.Add www.google.com into list and set it to "Block"
5.Click "Remove All Sites" button
6.Try to add www.google.com into list again

Actual Results:  
Can not add www.google.com into list any more.

Expected Results:  
Should be able to add any items user required.

Comment 1

[Lothar]

I can confirm this behavior with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0

Even reproduce steps 3. and 4. are not needed, after clicking at "remove all sites" the dialog has to be closed before new sites could be added.

Comment 2

[emily chen]

Confirm this bug on FireFox trunk build :
Mozilla/5.0(X11;U;SunOS sun4u;en-US;rv:1.9a3pre) Gecko/2007022801 Minefield/3.0a3pre

Comment 3

[Alfred Peng]

Confirmed for Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.8.1) Gecko/20061211 Firefox/2.0 on Solaris Nevada. And also Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9a2) Gecko/20070220 Firefox/3.0a2.

It seems to be not a Solaris specific bug as comment 1.

=>Change Hardware and OS.

Comment 4

[Jiaqin Shi]

Attachment: Patch V1

I wonder whether I should also modify the file "Permissionsutils.js". In the function deleteAll, "aItems = [];" seems no effect on this._permission, and I am not sure delete it or not.

Comment 5

[Asaf Romano (gone)]

hrm, I think the you could fix that by changing aItems = [] to aItems.splice(0), please test.

Comment 6

[Jiaqin Shi]

Attachment: Patch V2

Great! I use mano's suggestion, and it does work well. Thanks!

Comment 7

[Asaf Romano (gone)]

Comment on attachment 260683 [details] [diff] [review]
Patch V2

r=mano.

Comment 8

[Alfred Peng]

mano, thanks for the review. Do we need a sr for this before checking?

Comment 9

[Asaf Romano (gone)]

No.

Comment 10

[Alfred Peng]

Checking in browser/components/preferences/permissionsutils.js;
/cvsroot/mozilla/browser/components/preferences/permissionsutils.js,v  <--  permissionsutils.js
new revision: 1.5; previous revision: 1.4
done

=>FIXED