Closed Bug 357250 Opened 18 years ago Closed 18 years ago

Two accesskeys around German localized print dialog are inappropriately chosen

Categories

(Mozilla Localizations :: de / German, defect)

x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: lsaelzer, Assigned: atopal)

References

Details

(Keywords: verified1.8.1.1)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0

The German localized print dialog is using "l" as accesskey for "Alles" (print all).
I refer to bug https://bugzilla.mozilla.org/show_bug.cgi?id=303634 and the "XUL Accesskey FAQ and Policies" where an "l" should not be used as an accesskey.

I suggest using "a" at "(A)lles" (widely used) and maybe "m" at "Wie am Bilschir(m) angezeigt", if it's possible.


I just discovered another "problem": The accesskeys at "Datei" (File) menu for "(D)rucken..." and "Link sen(d)en" are the same ("d"). I suggest using the "L" here for "(L)ink senden", because its uppercase, first letter and unused.
If this should be in a extra bug report, please let me know.

I'm using the German localized version of FF2 RC3.

Reproducible: Always

Steps to Reproduce:
1. Go Datei -> Drucken... (File -> Print) or just press STRG+P
> I just discovered another "problem": The accesskeys at "Datei" (File) menu for
> "(D)rucken..." and "Link sen(d)en" are the same ("d"). I suggest using the "L"
> here for "(L)ink senden", because its uppercase, first letter and unused.
> If this should be in a extra bug report, please let me know.
> 
> I'm using the German localized version of FF2 RC3.

Confirm this issue in Mozilla/5.0 (Windows; U; Windows NT 5.0; de; rv:1.8.1) Gecko/20061010 Firefox/2.0, doesn`t happen in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

Assign this Bugreport to the DE Localiser
Assignee: nobody → kairo
Status: UNCONFIRMED → NEW
Component: Keyboard Navigation → de-AT / German-Austria
Ever confirmed: true
Product: Firefox → Mozilla Localizations
QA Contact: keyboard.navigation → mozilla
Assignee: kairo → a.topal
Accesskeys are in pretty bad shape generally, so thanks for pointing out. These will hopefully be adressed in a minor release after 2.0.
Blocks: 355389
Status: NEW → ASSIGNED
Okay, sounds crazy, but I can't find the corresponding accesskeys for the print dialog, they are certainly not in the same file as the labels and that's bad enough, I'll investigate this further, later. Here is the first patch for your second finding.
Attachment #245140 - Flags: approval1.8.1.1?
Comment on attachment 245140 [details] [diff] [review]
fixing double use of accesskey 

[de] send link accesskey fix approved for Firefox 2.0.0.1
Attachment #245140 - Flags: approval1.8.1.1? → approval1.8.1.1+
It seems to me that the print dialog is a native dialog on windows and mac, at least partially.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
That may be, but the accesskeys are correct in Word and in IE.
After looking at http://lxr.mozilla.org/mozilla1.8/source/toolkit/components/printing/content/printdialog.xul#95

I'm pretty sure the print dialog is mostly non-native on Windows, but I can't figure out how we add the accesskeys. At least Im very sure that there is no native dialog on Windows for printing each frame seperatly (even though IE provides that option in it's print dialog).
[mass-verified1.8.1.1 message, filter on this if you need to]

This bug has an approved patch, but not the verified1.8.1.1 keyword.

Please make sure that the approved patch is landed (add the fixed1.8.1.1 keyword then) and tested. If you verified that the bug in question is indeed fixed on the 1.8 branch nightlies, please add the verified1.8.1.1 keyword.

We need to get the QA activities around Firefox 2.0.0.1 up to speed so that we can feel good about releasing this update.
1. Accesskeys at print dialog are still in bad shape ("Alles" and "Wie am
Bilschirm angezeigt"). Please help Abdulkadir Topal here. 

2. Verified for accesskeys at "Datei" menu ("(D)rucken" and "(L)ink senden...").

Tested with "Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.1pre) Gecko/20061126 BonEcho/2.0.0.1pre".
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I noticed that the main part of the print dialog is always in German at my German Windows for every Mozilla product I use! That could mean setting accesskeys are probably not directly possible. Acrobat Reader 7 uses partly the same dialog with the same "problem". Windows and MS Office 2003 programs are using another (newer?) print dialog. So the problem resists probably in the way the dialog is called or rather which version of it is used...
Looking at http://lxr.mozilla.org/mozilla1.8/search?string=printdialog.xul, the xul dialog is only used on mac and unix, windows uses a (modified) native one.

There is no way for us to fix the accesskey on our side, without (uneducated guess) moving from PrintDlg to PrintDlgEx at http://lxr.mozilla.org/mozilla1.8/source/embedding/components/printingui/src/win/nsPrintDialogUtil.cpp#975.

Thus, resolving worksforme. Bug 122530 claims that we're using PrintDlgEx now, but I don't see the new printdialog on Minefield. Whichever.

Adding verified1.8.1.1 per reporters comment on the actually patched fix.
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Keywords: verified1.8.1.1
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: