357359 - Heavyweight function unqualified lookup finds Object.prototype slots before globals

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Simon Buchan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061002 SeaMonkey/1.5a
Build Identifier: cvs from mozilla/js @ 2006-10-20 17:11 NZDST

Any function with nested functions that references a global member will find Object.prototype members before the globals. Note that lightweight functions and accesses qualified with |this| find the correct variable.

Reproducible: Always

Steps to Reproduce:
Evaluate with jsshell (interactive or from .js file)

var foo = "Global";
Object.prototype.foo = "Object";
function heavy() {
    function nested() { print("Make heavy() heavyweight"); }
    print(foo);
    print(this.foo);
}
heavy();
Actual Results:  
Object
Global

Expected Results:  
Global
Global

Comment 1

[Brendan Eich [:brendan]]

Works for me:

js> var foo = "Global";
js> Object.prototype.foo = "Object";
Object
js> function heavy() {
    function nested() { print("Make heavy() heavyweight"); }
    print(foo);
    print(this.foo);
}
js> heavy();
Global
Global

What version of SpiderMonkey are you using?  This was fixed a while ago.

/be

Comment 2

[Simon Buchan]

(In reply to comment #1)
> What version of SpiderMonkey are you using?  This was fixed a while ago.
> 
I *thought* an up-to-date CVS trunk: I seem to have stuffed up the checkout though (/js/src instead of JSRef?). Sorry for your time!

If you can be bothered, could you let me know which bug this was handled in before? I searched several times, but I'm not used to Bugzilla's search.

Comment 3

[Brendan Eich [:brendan]]

(In reply to comment #2)
> If you can be bothered, could you let me know which bug this was handled in
> before? I searched several times, but I'm not used to Bugzilla's search.

Via cvs annotate and cvs log -r, bug 290774.

/be