357369 - nsIAbListener :: onItemPropertyChanged should report all properties (not just "DirName")

Status: RESOLVED WONTFIX

(Thunderbird :: Address Book, defect)

Description

[Andrei Pozolotin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7 XpcomViewer/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7 XpcomViewer/0.9

Hello,

apparently, there is omission by design:
http://lxr.mozilla.org/mailnews/source/mailnews/addrbook/public/nsIAbListener.idl#45
and nsIAbListener :: onItemPropertyChanged now really supports only "DirName" property;

onItemPropertyChanged  should also support all properties of 

nsIAbCard:
   http://www.xulplanet.com/references/xpcomref/ifaces/nsIAbCard.html
 and
nsIAbDirectory:
   http://www.xulplanet.com/references/xpcomref/ifaces/nsIAbDirectory.html
 and probably more(?)


SUGGESTED QUICKFIX:

add a new method:

void nsIAbListener :: onItemChanged( nsISupports oldItem, nsISupports NewItem )

this will let JS authors detect property changes by iterating over differences between oldItem & newItem properties;

Thank you.


Reproducible: Always




Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.8pre) Gecko/20061005 Thunderbird/1.5.0.7 - Build ID: 2006100505

Comment 1

[Joshua Cranmer [:jcranmer]]

onItemPropertyChanged is already called back when anything on the card changes; if the property could not be determined (or, more commonly, several things may have been changed), null is passed into both parameters.

JS authors can determine changes for what they care about by matching the saved values they have to what the current value is.