Show ID/classes in structure toolbar and allow to select element

RESOLVED FIXED in 0.1

Status

--
enhancement
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: glazou, Assigned: glazou)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
The structure toolbar should show when an element carries an ID or classes.
It should also allow to select an element clicking on its entry in the
structure toolbar.
(Assignee)

Comment 1

12 years ago
Created attachment 242857 [details] [diff] [review]
fix #1
(Assignee)

Comment 2

12 years ago
Created attachment 242861 [details] [diff] [review]
mucho better, fix #2
Attachment #242857 - Attachment is obsolete: true
(Assignee)

Comment 3

12 years ago
Comment on attachment 242861 [details] [diff] [review]
mucho better, fix #2

Kathy, can you review that one too ?
Attachment #242861 - Flags: review?(brade)
Comment on attachment 242861 [details] [diff] [review]
mucho better, fix #2

>+            newLabel.setAttribute("oncommand", "this.parentNode.selectNode(this)");

I have to really wonder about this.  Why can't you set a capturing or bubbling event listener on this (in a <handler> element on the binding)?  event.target would reflect the newLabel object, I'm pretty sure, and event.currentTarget == this.

Updated

12 years ago
Attachment #242861 - Flags: review?(brade) → review+
(Assignee)

Comment 5

12 years ago
fixed and checked in (trunk)
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 6

12 years ago
(In reply to comment #5)
> fixed and checked in (trunk)
> 

And where is dummyCommands.inc ?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

12 years ago
/me sends tortoiseCVS to /dev/null, second time it misses a cvs-added file in a week. Thanks paul, fixed.
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.