357449 - [reflow branch] Combobox dropdown button position is wrong?

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Mats Palmgren (inactive)]

[reflow branch] Combobox dropdown button height/position is wrong?

There is no assertion (bug 357044) for this testcase but perhaps it's the same
underlying issue...

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase #1

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm....  I'm not sure.  I clearly should have tested setting font size and height both... :(

Comment 3

[Mats Palmgren (inactive)]

The height seems to be correct, it's the position that is different from trunk.

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/style/forms.css&rev=3.118.2.1&root=/cvsroot&mark=195-200#181

FWIW, changing it to "vertical-align:top" gives the same rendering as trunk.

Comment 4

[Boris Zbarsky [:bzbarsky]]

MM.... so the problem here is that the display frame's bottom ends up below the actual display area or something?

I agree that vertical-align:top would make more sense here.  If it fixes the problem, let's do it.

Comment 5

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Yeah, this looks like a typo...

I was a bit curious why this works on trunk though since there is no
vertical-align declaration there. It seems we brute force 'top' in C++:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/forms/nsComboboxControlFrame.cpp&rev=1.376&root=/cvsroot&mark=876,888#858
Adding vertical-align:bottom!important (etc) on trunk has no effect.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 242941 [details] [diff] [review]
Patch rev. 1

Looks great.  Thanks!

Comment 7

[Boris Zbarsky [:bzbarsky]]

Oh, and please add to the layout regression tests?

Comment 8

[Mats Palmgren (inactive)]

Checked in on REFLOW_20060830_BRANCH at 2006-10-26 18:14 PDT.

Also added the testcase to the layout regression test suite on trunk.
layout/html/tests/formctls/bugs/bug357449.html

-> FIXED