357531 - [reflow branch] ASSERTION: space manager should be present

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Mats Palmgren (inactive)]

###!!! ASSERTION: space manager should be present iff not doing intrinsic widths: '!aSpaceManager == aIntrinsicWidthPass', file nsLineLayout.cpp, line 165
...
###!!! ASSERTION: reflow dirty lines failed: 'NS_SUCCEEDED(rv)', file nsBlockFrame.cpp, line 884


STEPS TO REPRODUCE
1. Load the attached testcase

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase #1

Comment 2

[Mats Palmgren (inactive)]

Attachment: Console messages loading Testcase #1

Comment 3

[Boris Zbarsky [:bzbarsky]]

This looks like a bug in nsFirstLetterFrame::Reflow -- when floating it constructs its own line layout, and it should be passing a space manager to it, I would think.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Maybe I should just drop the assertion -- there's no real need for a space manager here.  (And I removed the aIntrinsicWidthPass stuff).

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

But the "reflow dirty lines failed" assertion is more serious.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I fixed the space manager assertion by checking for first letter frames:

Checking in nsLineLayout.cpp;
/cvsroot/mozilla/layout/generic/nsLineLayout.cpp,v  <--  nsLineLayout.cpp
new revision: 3.239.2.4; previous revision: 3.239.2.3
done

I still want to look into the other assertion which is caused by:
WARNING: Content has no document.: file /builds/reflow/mozilla/layout/generic/nsTextFrame.cpp, line 5975

and is perhaps the same problem that led me to comment out an assertion on balsa.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Actually, I'm marking this fixed, and I'll file a new bug on the other assertions.