Closed Bug 357534 Opened 18 years ago Closed 18 years ago

Add fieldsets in show_bug.cgi

Categories

(Bugzilla :: User Interface, enhancement)

2.23.3
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

()

Details

Attachments

(1 file, 1 obsolete file)

From our discussion on IRC:

(22:54:27) mkanat: LpSolit: Here's what I think:
(22:54:31) LpSolit: hmm, I'm fine in grouping 1 2 and 4
(22:54:37) mkanat: You combine 1, 2, and 4 into a single table.
(22:54:42) mkanat: Summary goes at the top, in a colspan.
(22:54:52) mkanat: And the single fieldset is called "Details."
(22:55:10) LpSolit: sounds good

1, 2 and 4 are references to http://landfill.bugzilla.org/qa30pg/attachment.cgi?id=350
Attached patch patch, v1 (obsolete) — Splinter Review
good luck...
Attachment #243054 - Flags: review?(mkanat)
Attached patch patch, v1.1Splinter Review
unbitrotten patch
Attachment #243054 - Attachment is obsolete: true
Attachment #243057 - Flags: review?(mkanat)
Attachment #243054 - Flags: review?(mkanat)
Comment on attachment 243057 [details] [diff] [review]
patch, v1.1

Okay, this looks great in the UI, and it validates. It's such a big patch, I didn't actually do a code review of it (other than just looking it over briefly), but it actually *works* well, and that's what matters to me about the UI. :-)
Attachment #243057 - Flags: review?(mkanat) → review+
Flags: approval?
Note to self: write "Depends on" instead of "Depends on" on checkin so that this label remains on a single line.
Status: NEW → ASSIGNED
Flags: approval? → approval+
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.89; previous revision: 1.88
done
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.24; previous revision: 1.23
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: