Add fieldsets in show_bug.cgi

RESOLVED FIXED in Bugzilla 3.0

Status

()

--
enhancement
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: LpSolit, Assigned: LpSolit)

Tracking

2.23.3
Bugzilla 3.0
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
From our discussion on IRC:

(22:54:27) mkanat: LpSolit: Here's what I think:
(22:54:31) LpSolit: hmm, I'm fine in grouping 1 2 and 4
(22:54:37) mkanat: You combine 1, 2, and 4 into a single table.
(22:54:42) mkanat: Summary goes at the top, in a colspan.
(22:54:52) mkanat: And the single fieldset is called "Details."
(22:55:10) LpSolit: sounds good

1, 2 and 4 are references to http://landfill.bugzilla.org/qa30pg/attachment.cgi?id=350
(Assignee)

Comment 1

12 years ago
Created attachment 243054 [details] [diff] [review]
patch, v1

good luck...
Attachment #243054 - Flags: review?(mkanat)
(Assignee)

Comment 2

12 years ago
Created attachment 243057 [details] [diff] [review]
patch, v1.1

unbitrotten patch
Attachment #243054 - Attachment is obsolete: true
Attachment #243057 - Flags: review?(mkanat)
Attachment #243054 - Flags: review?(mkanat)

Comment 3

12 years ago
Comment on attachment 243057 [details] [diff] [review]
patch, v1.1

Okay, this looks great in the UI, and it validates. It's such a big patch, I didn't actually do a code review of it (other than just looking it over briefly), but it actually *works* well, and that's what matters to me about the UI. :-)
Attachment #243057 - Flags: review?(mkanat) → review+

Updated

12 years ago
Flags: approval?
(Assignee)

Comment 4

12 years ago
Note to self: write "Depends on" instead of "Depends on" on checkin so that this label remains on a single line.
Status: NEW → ASSIGNED
Flags: approval? → approval+
(Assignee)

Comment 5

12 years ago
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.89; previous revision: 1.88
done
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.24; previous revision: 1.23
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.