357641 - --register-user doesn't report error/reason when exit status != 0

Status: RESOLVED INCOMPLETE

(Toolkit Graveyard :: XULRunner, defect)

Description

[Darryl Miles]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-GB; rv:1.8.0.7) Gecko/20060929 SeaMonkey/1.0.5
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-GB; rv:1.8.0.7) Gecko/20060929 SeaMonkey/1.0.5

$  ./xulrunner --register-user
nsStringStats
 => mAllocCount:              3
 => mReallocCount:            0
 => mFreeCount:               3
 => mShareCount:              2
 => mAdoptCount:              0
 => mAdoptFreeCount:          0
$ echo $?
2

XULRunner should always indicate and error occured when exiting with a non-zero exit status.  Even if its not possible to provide an explicit cause of the error, by not printing any message the user can be left with the belief that it was sucessfull.

Ideally a specific error message should also be displayed.  In the cause above I have the 'strace' output below:

2561  getcwd("/usr/src/mozilla_1_8_branch/dist/bin", 4096) = 37
2561  lstat64("/usr/src/mozilla_1_8_branch/dist/bin/xulrunner-bin", {st_mode=S_IFREG|0755, st_size=181373, ...}) = 0
2561  stat64("/usr/src/mozilla_1_8_branch/dist/bin/xulrunner-bin", {st_mode=S_IFREG|0755, st_size=181373, ...}) = 0
2561  open("/usr/src/mozilla_1_8_branch/dist/bin/user.reginfo", O_RDWR|O_CREAT|O_LARGEFILE, 0664) = -1 EACCES (Permission denied)
2561  fstat64(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136, 0), ...}) = 0
2561  mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb75f3000
2561  write(1, "nsStringStats\n", 14)   = 14
2561  write(1, " => mAllocCount:              3\n", 32) = 32
2561  write(1, " => mReallocCount:            0\n", 32) = 32
2561  write(1, " => mFreeCount:               3\n", 32) = 32
2561  write(1, " => mShareCount:              2\n", 32) = 32
2561  write(1, " => mAdoptCount:              0\n", 32) = 32
2561  write(1, " => mAdoptFreeCount:          0\n", 32) = 32
2561  munmap(0xb75f3000, 4096)          = 0
2561  exit_group(2)                     = ?


Notice that even when executing --register-user is attempts to write a file into the base location of the installation.  But the current users does not have write permission for that location (just like a non-root users wouldn't have permission to write into the system install location of xulrunner, /usr/lib/xulrunner-x.y.z/).


Tested versions are 1.8.0.8 (MOZILLA_1_8_0_BRANCH) and 1.8.1 (MOZILLA_1_8_BRANCH).


Reproducible: Always

Comment 1

[Benjamin Smedberg]

code is gone