357761 - tiled image drawing somewhat broken

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

nsThebesImage::DrawTile currently transforms the destination image rect into the CTM's space, and then resets the CTM before drawing.  This has the unfortunate side effect of always tiling untransformed images; thus under <xul:transform> or <svg:foreignObject>, background images are rendered at the wrong scale.

DrawTile with Thebes also breaks bug 113561, where a piece of the GIF image is to be rendered that's smaller than the actual containing canvas.  We're tiling just the small frame size, and not the actual container size.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix nsThebesImage::DrawTile

... and call it ThebesDrawTile, so we can have a different signature.  Nothing else in the tree uses DrawTile, and I'd like to deprecate those APIs (and even get rid of them) for 1.9 to simplify the entire gfx stack.  (Getting rid of most XPCOM in the gfx stack would be a worthy and achievable goal for 1.9, I think.)

This fixes the regression of bug 113561.  It /may/ re-introduce an issue on linux with broken X servers and the REPEAT render mode.