357892 - AUS should not check for a newer build id for release channels

Status: RESOLVED FIXED

(AUS Graveyard :: Systems, defect)

Description

[Michael Morgan [:morgamic]]

Currently AUS will not allow an update if the destination build is older than the client build, or "from" build.  Example:

Client: 2006102410
AUS: 2006102400
Result: No Update

It should receive an update, assuming it's non-nightly and the update data exists.  For nightlies, this check should remain.  Will attach patch.

Comment 1

[Michael Morgan [:morgamic]]

Attachment: Patch to remove build comparison and centralize some of the isPatch() code.

This patch rearranges some of the isNewBuild() and isPatch() checks to make things  a bit saner, and also allow for a better place (isPatch()) to plug in business logic that should/shouldn't stop an update this is otherwise fine from happening.

Comment 2

[Michael Morgan [:morgamic]]

Disregard the config-dist changes -- those are already committed.

Comment 3

[Michael Morgan [:morgamic]]

In the case where we are overriding a nightly channel to test, it is still doing the build ID check, since those were only done for nightlies.  So basically it can't do it on nightlies unless it's only using datasource 2 (incoming/2) -- which is going to take some adjustment.  Other option is to use a betatest channel.  I should probably keep nightly release behavior (incoming/3) and nightly non-release behavior (incoming/2) completely separate.

Comment 4

[Michael Morgan [:morgamic]]

Attachment: v2, to accomodate exception for nightly release testing

This is a fix to make sure the check only happens when the channel is nightly _and it is using the nightly data source_.

Comment 5

[Michael Morgan [:morgamic]]

Attachment: v3, cumulative patch against AUS2_PRODUCTION

This is a cumulative patch, including the fallback code that was already reviewed.  This should give a better picture of the changes involved.  Use bug 358211 as a reference for fallback code.

Comment 6

[J. Paul Reed [:preed]]

Comment on attachment 243862 [details] [diff] [review]
v3, cumulative patch against AUS2_PRODUCTION

With my nitpick that it would make me happy if isNewBuild became isNewerBuild(), which in turn can become:

    function isNewBuild($build) {
        return ($this->build > $build);
    }

Comment 7

[Michael Morgan [:morgamic]]

This was checked in this afternoon.  I thought I had checked it in last week, but all I did was re-tag AUS2_STAGING without a cvs ci, which basically kept it where it was at.