AUS should not check for a newer build id for release channels

RESOLVED FIXED in 4.x (triaged)

Status

defect
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: morgamic, Assigned: morgamic)

Tracking

4.x (triaged)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

13 years ago
Currently AUS will not allow an update if the destination build is older than the client build, or "from" build.  Example:

Client: 2006102410
AUS: 2006102400
Result: No Update

It should receive an update, assuming it's non-nightly and the update data exists.  For nightlies, this check should remain.  Will attach patch.
Assignee

Comment 1

13 years ago
This patch rearranges some of the isNewBuild() and isPatch() checks to make things  a bit saner, and also allow for a better place (isPatch()) to plug in business logic that should/shouldn't stop an update this is otherwise fine from happening.
Attachment #243409 - Flags: first-review?
Assignee

Updated

13 years ago
Attachment #243409 - Flags: first-review? → first-review?(preed)
Assignee

Comment 2

13 years ago
Disregard the config-dist changes -- those are already committed.
Status: NEW → ASSIGNED
Assignee

Comment 3

13 years ago
In the case where we are overriding a nightly channel to test, it is still doing the build ID check, since those were only done for nightlies.  So basically it can't do it on nightlies unless it's only using datasource 2 (incoming/2) -- which is going to take some adjustment.  Other option is to use a betatest channel.  I should probably keep nightly release behavior (incoming/3) and nightly non-release behavior (incoming/2) completely separate.
Assignee

Comment 4

13 years ago
This is a fix to make sure the check only happens when the channel is nightly _and it is using the nightly data source_.
Attachment #243409 - Attachment is obsolete: true
Attachment #243430 - Flags: first-review?(preed)
Attachment #243409 - Flags: first-review?(preed)
Assignee

Comment 5

13 years ago
This is a cumulative patch, including the fallback code that was already reviewed.  This should give a better picture of the changes involved.  Use bug 358211 as a reference for fallback code.
Attachment #243430 - Attachment is obsolete: true
Attachment #243862 - Flags: first-review?
Attachment #243430 - Flags: first-review?(preed)
Assignee

Updated

13 years ago
Attachment #243862 - Flags: first-review? → first-review?(preed)
Comment on attachment 243862 [details] [diff] [review]
v3, cumulative patch against AUS2_PRODUCTION

With my nitpick that it would make me happy if isNewBuild became isNewerBuild(), which in turn can become:

    function isNewBuild($build) {
        return ($this->build > $build);
    }
Attachment #243862 - Flags: first-review?(preed) → first-review+
Assignee

Comment 7

13 years ago
This was checked in this afternoon.  I thought I had checked it in last week, but all I did was re-tag AUS2_STAGING without a cvs ci, which basically kept it where it was at.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Summary: AUS should not check for a newer build id for non-nightly channels → AUS should not check for a newer build id for release channels
You need to log in before you can comment on or make changes to this bug.