Nagios nightly files check doesn't complain if file is completely missing

RESOLVED FIXED

Status

mozilla.org Graveyard
Server Operations
RESOLVED FIXED
11 years ago
3 years ago

People

(Reporter: nthomas, Assigned: justdave)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Until recently the controls files for the Nagios check on nightly builds (eg [1]) had references to complete update files in the style
   firefox-2.0.en-US.win32.mar
but the files are now named like
   firefox-2.0.en-US.win32.complete.mar

There is an update file for each the three major platforms, but the check didn't report that any were missing.

Simple patch coming up.

[1] 
http://lxr.mozilla.org/mozilla/source/tools/tinderbox-configs/monitoring/Firefox_mozilla1.8.txt
(Reporter)

Comment 1

11 years ago
Created attachment 243413 [details] [diff] [review]
Add the CRITICAL keyword to the echo

check_nightly_builds2 does a grep for CRITICAL on the output of check_nightly_builds, so include that in the error.

Dave, seeking your review (and flags in this component :-)
(Reporter)

Comment 2

11 years ago
Could we sneak in a s/threshhold/threshold/g on check_nightly_builds too ?
r=justdave.

Deployed. (with spelling correction)
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.