357899 - Nagios nightly files check doesn't complain if file is completely missing

Status: RESOLVED FIXED

Description

[Nick Thomas [:nthomas] (UTC+13)]

Until recently the controls files for the Nagios check on nightly builds (eg [1]) had references to complete update files in the style
   firefox-2.0.en-US.win32.mar
but the files are now named like
   firefox-2.0.en-US.win32.complete.mar

There is an update file for each the three major platforms, but the check didn't report that any were missing.

Simple patch coming up.

[1] 
http://lxr.mozilla.org/mozilla/source/tools/tinderbox-configs/monitoring/Firefox_mozilla1.8.txt

Comment 1

[Nick Thomas [:nthomas] (UTC+13)]

Created attachment 243413 [details] [diff] [review]
Add the CRITICAL keyword to the echo

check_nightly_builds2 does a grep for CRITICAL on the output of check_nightly_builds, so include that in the error.

Dave, seeking your review (and flags in this component :-)

Comment 2

[Nick Thomas [:nthomas] (UTC+13)]

Could we sneak in a s/threshhold/threshold/g on check_nightly_builds too ?

Comment 3

[Dave Miller [:justdave] ([e-mail])]

r=justdave.

Deployed. (with spelling correction)