Closed Bug 357914 Opened 18 years ago Closed 18 years ago

"Pick application" on menu on RSS overview page doesn't always work

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)

2.0 Branch

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 3 alpha1

People

(Reporter: cagg, Assigned: asaf)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; fr; rv:1.8.1) Gecko/20061010 Firefox/2.0 Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; fr; rv:1.8.1) Gecko/20061010 Firefox/2.0 When on the overview page of an RSS feed, the menu used for selecting an optional application for subscribing to the feed has an option to pick another application. On Mac, a standard way to activate a menu item is to click on the menu then while keeping the button clicked move down to the desired option and release. When I do this for the Pick Application option the option is selected however no Open dialog opens to select the application. If I click on the menu then click on the option (ie. releasing button in between) the item works properly. Reproducible: Always Steps to Reproduce: see Details
OS: Mac OS X 10.3 → Mac OS X 10.4
Version: unspecified → 2.0 Branch
Assignee: nobody → mano
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Target Milestone: --- → Firefox 3
Attached patch patch (obsolete) — Splinter Review
So, this changes the behavior a bit so pressing enter on the item while the menu is open opens the file picker, I consider this an improvement over the initial fix.
Attachment #245933 - Flags: review?(gavin.sharp)
Status: NEW → ASSIGNED
OS: Mac OS X 10.4 → All
Priority: P3 → P2
Hardware: Macintosh → All
Target Milestone: Firefox 3 → Firefox 3 alpha1
Comment on attachment 245933 [details] [diff] [review] patch >Index: browser/components/feeds/src/FeedWriter.js >+ /* See bug 351263, in that case the file picker will be shown >+ * only when subscribing */ I think this comment could be clearer, something like: Make sure to not steal focus if the "Choose Application" item is being selected with the keyboard. We do this by ignoring command events while the dropdown is closed (user arrowing through the combobox), but handling them while the combobox dropdown is open (user pressed enter when an item was selected). If we don't show the filepicker here, it will be shown when clicking "Subscribe". See bug 351263. Or maybe that's too wordy, and you can just replace "in that case" with "in the keyboard selection case". r=me on the parts that aren't bug 361186.
Attachment #245933 - Flags: review?(gavin.sharp) → review+
Attached patch for checkinSplinter Review
Thanks Gavin.
Attachment #245933 - Attachment is obsolete: true
mozilla/browser/components/feeds/src/FeedWriter.js 1.28
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: blocking1.8.1.1?
Definitely not blocking 1.8.1.1 -- not sure whether we want it in future branch releases so "wanted?"
Flags: wanted1.8.1.x?
Flags: blocking1.8.1.1?
Flags: blocking1.8.1.1-
Do we want this for the 1.8.1.2? if so ask for approval on the appropriate patch.
Flags: wanted1.8.1.x? → wanted1.8.1.x+
Ask for approval if you think it's appropriate for the branch, we're not going to block on it.
Flags: wanted1.8.1.x+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: